Fix indentation parsing to conform to Ink spec - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
Fixes a bug in the compiler which misinterpreted indentation as weave nesting, which led to choices getting dropped in bladeink-compiler that don't get dropped by Inklecate.
Inklecate explicitly ignores whitespace for choices and uses bullet count instead. Blade-ink-java and blake-ink-python also follow this rule; bug is exclusive to blade-ink-rs's compiler.
Breaking change
2.0.0 just shipped last week, so it's kind of awkward to push another breaking change like this so soon. However it does bring blade-ink-rs in line with the Ink spec and makes it compile stories to run the same way a dev previewing them in Inky would see them run.