Skip to content

Bug fix: Make object revision match datastore revision - #180

Open
aaandreeew wants to merge 3 commits into
blacksmithgu:masterfrom
aaandreeew:bug/object-revision-not-matching-datastore-revision
Open

Bug fix: Make object revision match datastore revision#180
aaandreeew wants to merge 3 commits into
blacksmithgu:masterfrom
aaandreeew:bug/object-revision-not-matching-datastore-revision

Conversation

@aaandreeew

@aaandreeew aaandreeew commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #179.

Upon changes in the vault, the revision of any newly-modified object matches that of the datastore.

I have hand-tested this in a vault with the following datacore block while editing another page in a split view. I compared the results before and after this change.

return function View() {
    const revision = dc.useIndexUpdates();
    const pages = dc.useMemo(
        () => dc.query(`@page and $revision >= ${revision - 1}`),
        [revision]
    );
    
    return <>
        Revision: {revision}
        <dc.List
            rows={pages}
            renderer={page => `${page.$path}: ${page.$revision}`}
        />
    </>
}

PS: Could someone explain the proper way to work with feature branches on a fork when fixing bugs? As you can see, this PR contains two redundant commits relating to my last bugfix. I made my last bugfix on a feature branch that got merged into this repo's main. That merge commit was then pulled into in my fork's main branch as expected. To get rid of that last feature branch, I just merged it into my main and deleted it, since that's what I normally do. But now, since this PR's branch is based on that, those merge commits (not squashed, but that's only part of the issue) are included, even thought they're redundant.

Block IDs at the end of lines need leading whitespace, no trailing
whitespace, and contain only Latin letters, numbers, or hyphens. I also
split the cleaning operation between removing the block ID and removing
everything after and including the first inline field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: $revision of newly-stored objects never matches current datastore revision

1 participant