Bug fix: Make object revision match datastore revision - #180
Open
aaandreeew wants to merge 3 commits into
Open
Conversation
Block IDs at the end of lines need leading whitespace, no trailing whitespace, and contain only Latin letters, numbers, or hyphens. I also split the cleaning operation between removing the block ID and removing everything after and including the first inline field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179.
Upon changes in the vault, the revision of any newly-modified object matches that of the datastore.
I have hand-tested this in a vault with the following datacore block while editing another page in a split view. I compared the results before and after this change.
PS: Could someone explain the proper way to work with feature branches on a fork when fixing bugs? As you can see, this PR contains two redundant commits relating to my last bugfix. I made my last bugfix on a feature branch that got merged into this repo's main. That merge commit was then pulled into in my fork's main branch as expected. To get rid of that last feature branch, I just merged it into my main and deleted it, since that's what I normally do. But now, since this PR's branch is based on that, those merge commits (not squashed, but that's only part of the issue) are included, even thought they're redundant.