Land Data.Show and the show method - #134
Merged
Merged
Conversation
Add stdlib/lib/Data/Show.purs: the Show class, its show method, and the Boolean, Int, Number, Char, String, Unit, and Array a instances. Prelude re-exports the class and method, and stdlib/lib/trusted loads the module after Data.Semiring. Number rendering is library code over the numeric primitives, not a new intrinsic and not a correctly rounded ECMAScript conversion. Records, Maybe, Either, and Tuple stay out: records need reflectSymbol, and the other modules belong to later slices. logShow and assertEqual stay with #95. On this master, L2 passing resolution moves from 245/413 to 253/413 and other P3 blockers from 107 to 99. show and Show are no longer first-blocker names. D-04 and D-15 record the measurement.
The module is in stdlib/lib/trusted, so the order assertion has to name it or loads_the_standard_library_from_disk_in_trusted_order fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stdlib/lib/Data/Show.purs: the Show class, its show method, and the
Boolean, Int, Number, Char, String, Unit, and Array a instances. Prelude
re-exports the class and method, and stdlib/lib/trusted loads the module
after Data.Semiring.
Number rendering is library code over the numeric primitives, not a new
intrinsic and not a correctly rounded ECMAScript conversion. Records,
Maybe, Either, and Tuple stay out: records need reflectSymbol, and the
other modules belong to later slices. logShow and assertEqual stay with
#95.
On this master, L2 passing resolution moves from 245/413 to 253/413 and
other P3 blockers from 107 to 99. show and Show are no longer first-blocker
names. D-04 and D-15 record the measurement.