Skip to content

PM-42349: bug: Hide static password mask when field is blank #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-livefront merged 1 commit into from
Sep 10, 2026
Merged

PM-42349: bug: Hide static password mask when field is blank #7376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...kotlin/com/bitwarden/ui/platform/components/util/BitwardenPasswordVisualTransformation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.input.OffsetMapping
import androidx.compose.ui.text.input.TransformedText
import androidx.compose.ui.text.input.VisualTransformation
import com.bitwarden.ui.platform.base.util.toAnnotatedString

/**
* Returns a [VisualTransformation] that masks text with [mask]. When [staticCharacterCount] is
Comment thread
david-livefront marked this conversation as resolved.
* non-null, the transformed text always contains that number of mask characters.
* non-null and the text is non-empty, the transformed text contains that number of mask
* characters. Blank text is never masked.
*/
@Composable
fun passwordVisualTransformation(
Expand All @@ -30,10 +32,11 @@ private class BitwardenPasswordVisualTransformation(
override fun filter(
text: AnnotatedString,
): TransformedText = TransformedText(
AnnotatedString(
mask.toString().repeat(n = staticCharacterCount ?: text.text.length),
),
object : OffsetMapping {
text = mask
.toString()
.repeat(staticCharacterCount?.takeIf { text.text.isNotEmpty() } ?: text.text.length)
.toAnnotatedString(),
offsetMapping = object : OffsetMapping {
override fun originalToTransformed(
offset: Int,
): Int = staticCharacterCount?.let { offset.coerceAtMost(it) } ?: offset
Expand Down
Loading