Skip to content

🍒 PM-43235: bug: Remove edit button for disabled Send types - #7375

Merged
david-livefront merged 1 commit into
release/2026.9-rc62from
PM-43235-block-editing-disallowed-sends-cherry
Sep 10, 2026
Merged

🍒 PM-43235: bug: Remove edit button for disabled Send types#7375
david-livefront merged 1 commit into
release/2026.9-rc62from
PM-43235-block-editing-disallowed-sends-cherry

Conversation

@david-livefront

@david-livefront david-livefront commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

🍒

🎟️ Tracking

PM-43235

📔 Objective

This PR updates the SendScreen, SearchScreen, and VaultItemListingScreen to disable the edit button for Sends that are no longer allowed per policy.

@david-livefront
david-livefront requested a review from a team as a code owner September 9, 2026 17:00
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This cherry-pick to release/2026.9-rc62 threads a policy-derived allowedTypes list into SendData.toViewState, marking each SendItem with isEditable so SendListItem drops the Edit overflow entry for Send types the organization policy disallows. The patch is byte-identical to the already-merged commit 8df1653 on the source branch, so no divergence was introduced by the pick. Nulling the Edit entry is safe because persistentListOfNotNull already backs the selection list, the new SendType.ITEM -> TODO(...) branch follows the established convention in this file and nine other call sites, and Clock resolves through the existing CoreModule Hilt provider. All call sites of the two changed signatures were updated, and unit and Compose tests cover the policy-restricted, unrestricted, and per-type editable cases.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.96%. Comparing base (7d1fdd8) to head (4a5be8a).

Files with missing lines Patch % Lines
...it/bitwarden/ui/tools/feature/send/SendListItem.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           release/2026.9-rc62    #7375      +/-   ##
=======================================================
- Coverage                86.21%   85.96%   -0.25%     
=======================================================
  Files                      901     1042     +141     
  Lines                    66274    68953    +2679     
  Branches                 10172    10248      +76     
=======================================================
+ Hits                     57135    59274    +2139     
- Misses                    5561     6068     +507     
- Partials                  3578     3611      +33     
Flag Coverage Δ
app-data 18.53% <0.00%> (+0.14%) ⬆️
app-ui-auth-tools 19.09% <90.90%> (+0.34%) ⬆️
app-ui-platform 16.83% <10.00%> (+0.53%) ⬆️
app-ui-vault 27.63% <10.00%> (+0.55%) ⬆️
authenticator 6.00% <0.00%> (-0.02%) ⬇️
lib-core-network-bridge 3.98% <0.00%> (-0.06%) ⬇️
lib-data-ui 1.23% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront
david-livefront force-pushed the PM-43235-block-editing-disallowed-sends-cherry branch 3 times, most recently from 00100a9 to ecf35f8 Compare September 9, 2026 19:18
@david-livefront
david-livefront force-pushed the PM-43235-block-editing-disallowed-sends-cherry branch from ecf35f8 to 4a5be8a Compare September 9, 2026 21:16

@aj-rosado aj-rosado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront
david-livefront merged commit ad72b56 into release/2026.9-rc62 Sep 10, 2026
23 checks passed
@david-livefront
david-livefront deleted the PM-43235-block-editing-disallowed-sends-cherry branch September 10, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants