[PM-41296] feat: Display Identities vault list when autofilling for an Identity

[aj-rosado]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41296

📔 Objective

Displays the vault item list for manual selection when autofilling an Identity field, matching existing Login and Card autofill behavior.

• Adds Type.IDENTITY to AutofillSelectionData and updates the call sites that branch on it.
• Filters the vault item listing to identity items for this selection type.
• Adds test coverage for the new type.

📸 Screenshots

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of AutofillSelectionData.Type.IDENTITY and the call sites that branch on it: the AutofillPartition.Identity mapping in FilledDataExtensions, the root-nav listing-type mapping, the add-edit default content, and the vault item listing filter plus app bar title. All four when expressions over the enum were updated, so exhaustiveness holds, and the new IDENTITY branches mirror the existing CARD handling (type filter with failures cleared, no URI matching). The downstream fill path is type-agnostic — completeAutofillSelection branches only on Framework, and CipherView.toAutofillCipherProvider already supplies AutofillCipher.Identity — so selecting an identity from the list completes correctly. The createMockDisplayItemForCipher identity branch now honors its subtitleTestTag/isAutofill/isCredentialCreation/shouldShowMasterPasswordReprompt parameters, whose defaults match the previously hardcoded values, so existing callers are unaffected.

Code Review Details

No findings.

PR Metadata Assessment

• ❓ QUESTION: The Screenshots section is still a placeholder, but this change introduces a new user-visible screen state and a new string (identities_for_x, "Identities for %s"). Could screenshots of the identity selection list and its app bar title be added so the copy can be confirmed against design?

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.39%. Comparing base (43f36d7) to head (7152a43).

Files with missing lines	Patch %	Lines
...twarden/data/autofill/util/FilledDataExtensions.kt	0.00%	1 Missing ⚠️
...t/feature/itemlisting/VaultItemListingViewModel.kt	85.71%	1 Missing ⚠️

Additional details and impacted files

@@                               Coverage Diff                               @@
##           PM-41295/identity-autofill-multiple-address    #7373      +/-   ##
===============================================================================
- Coverage                                        85.77%   85.39%   -0.39%     
===============================================================================
  Files                                             1056     1061       +5     
  Lines                                            69259    69526     +267     
  Branches                                         10330    10319      -11     
===============================================================================
- Hits                                             59409    59369      -40     
- Misses                                            6225     6534     +309     
+ Partials                                          3625     3623       -2     

Flag	Coverage Δ
app-data	18.66% <0.00%> (-0.02%)	⬇️
app-ui-auth-tools	19.03% <0.00%> (-0.01%)	⬇️
app-ui-platform	16.81% <10.00%> (+<0.01%)	⬆️
app-ui-vault	27.59% <70.00%> (-0.01%)	⬇️
authenticator	5.98% <0.00%> (-0.01%)	⬇️
lib-core-network-bridge	4.03% <0.00%> (-0.02%)	⬇️
lib-data-ui	1.18% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.