PM-43250: chore: Change email param on 'hashPassword' to salt

[david-livefront]

🎟️ Tracking

PM-43250

📔 Objective

This PR renames the email parameter on hashPassword to salt. This will make things clearer moving forward as we migrate away from using the email as the salt.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the rename of the hashPassword email parameter to salt across AuthSdkSource, AuthSdkSourceImpl, AuthRepositoryImpl, VaultLockManagerImpl, and their tests. The rename is purely nominal — AuthSdkSourceImpl still forwards the value to the SDK's email parameter with a clarifying comment, and all four production call sites still pass the account email, so there is no behavior or crypto change. All call sites were updated consistently and no references to the old parameter name remain. The AuthRepositoryTest restructure from companion object constants to file-level private constants matches the convention used across the other test files in data/auth.

Code Review Details

• ♻️ : Test fixture salts changed from a distinct literal to SALT (= EMAIL), so the login tests can no longer detect email-for-salt substitution
  • app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt:7434

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.81%. Comparing base (051b2ac) to head (ab90425).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7372      +/-   ##
==========================================
+ Coverage   85.73%   85.81%   +0.08%     
==========================================
  Files        1056      946     -110     
  Lines       69016    67915    -1101     
  Branches    10279    10214      -65     
==========================================
- Hits        59170    58281     -889     
+ Misses       6233     6044     -189     
+ Partials     3613     3590      -23     

Flag	Coverage Δ
app-data	17.87% <100.00%> (-0.53%)	⬇️
app-ui-auth-tools	18.80% <0.00%> (-0.12%)	⬇️
app-ui-platform	16.29% <0.00%> (-0.38%)	⬇️
app-ui-vault	27.68% <0.00%> (-0.01%)	⬇️
authenticator	6.01% <0.00%> (+0.02%)	⬆️
lib-core-network-bridge	4.03% <0.00%> (-0.03%)	⬇️
lib-data-ui	1.18% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.