Skip to content

VULN-988: bug: Additional GMS validation for CXP export - #7367

Draft
david-livefront wants to merge 1 commit into
mainfrom
VULN-988-gms-validation
Draft

VULN-988: bug: Additional GMS validation for CXP export#7367
david-livefront wants to merge 1 commit into
mainfrom
VULN-988-gms-validation

Conversation

@david-livefront

@david-livefront david-livefront commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

VULN-988

📔 Objective

This PR updates the VerifyPasswordScreen to validate the calling package before allowing the user to export their vault.

@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug labels Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.59524% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.79%. Comparing base (d4651f2) to head (9b0eb3d).

Files with missing lines Patch % Lines
...exportitems/verifypassword/VerifyPasswordScreen.kt 53.22% 29 Missing ⚠️
.../verifypassword/handlers/VerifyPasswordHandlers.kt 0.00% 6 Missing ⚠️
...ortitems/verifypassword/VerifyPasswordViewModel.kt 95.78% 3 Missing and 1 partial ⚠️
...xportitems/selectaccount/SelectAccountViewModel.kt 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7367      +/-   ##
==========================================
- Coverage   86.44%   85.79%   -0.66%     
==========================================
  Files         927      947      +20     
  Lines       67101    68100     +999     
  Branches    10182    10225      +43     
==========================================
+ Hits        58006    58424     +418     
- Misses       5516     6086     +570     
- Partials     3579     3590      +11     
Flag Coverage Δ
app-data 18.37% <0.00%> (+0.33%) ⬆️
app-ui-auth-tools 18.58% <0.00%> (-0.05%) ⬇️
app-ui-platform 16.58% <0.00%> (+0.29%) ⬆️
app-ui-vault 27.77% <75.59%> (+0.04%) ⬆️
authenticator 6.01% <0.00%> (-0.04%) ⬇️
lib-core-network-bridge 4.04% <0.00%> (-0.03%) ⬇️
lib-data-ui 1.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant