Skip to content

Update SDK to 3.0.0-8736-dac9ec1a - #7365

Open
bw-ghapp[bot] wants to merge 3 commits into
mainfrom
sdlc/sdk-update
Open

Update SDK to 3.0.0-8736-dac9ec1a#7365
bw-ghapp[bot] wants to merge 3 commits into
mainfrom
sdlc/sdk-update

Conversation

@bw-ghapp

@bw-ghapp bw-ghapp Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Updates the SDK version from 3.0.0-8685-752729a9 to com.bitwarden:sdk-android 3.0.0-8736-dac9ec1a

What's Changed

Raw changelog
- [PM-42963 ]Retry failed Send deletes so uploads-that-fail don't orphan a Send (#1458)
- Extract AnyMap from the state registry (#1454)
- [PM-42032] feat: add data models for policies (excluding send controls and URI match defaults) (#1414)

@bw-ghapp bw-ghapp Bot added automated-pr PR created by workflow or other automation t:deps Change Type - Dependencies labels Sep 8, 2026
@bw-ghapp
bw-ghapp Bot requested review from a team and david-livefront as code owners September 8, 2026 18:46
@bw-ghapp bw-ghapp Bot added automated-pr PR created by workflow or other automation t:deps Change Type - Dependencies labels Sep 8, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context labels Sep 8, 2026
@claude

claude Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @bw-ghapp[bot]'s task in 3m 0s —— View job


SDK bump evaluated

3.0.0-8685-752729a93.0.0-8736-dac9ec1a3 sdk-internal commits.

Note: the PR title/body describe …-8717-e56c2815, but two further bumps have landed on this branch since (…-8715-07f075e3, then …-8736-dac9ec1a). This evaluation covers the full range against main.

Compile-time breaks

None found. app:compileStandardDebugKotlin and authenticator:compileDebugKotlin both succeed against the new artifact (verified the compile classpath resolves to com.bitwarden:sdk-android:3.0.0-8736-dac9ec1a).

The one genuinely breaking binding-surface change in range — PolicyDataType (a uniffi::Enum) in dac9ec1a (bitwarden/sdk-internal#1414) — renames MasterPasswordPolicyResponseMasterPasswordPolicyData and converts six unit variants (PasswordGenerator, OrganizationDataOwnership, SendOptions, ResetPassword, MaximumVaultTimeout, AutomaticAppLogIn, OrganizationUserNotification, FillAssist) into data-carrying variants. No Android call sites: the repo never references PolicyDataType, MasterPasswordPolicyResponse/Data, EnforcedPolicyErased, or getEnforced/getEnforcedErased. The only SDK policy surface Android touches is globalClient.policies().filterByType(...) (app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt:238) with PolicyType, PolicyView, and OrganizationUserPolicyContext — all three unchanged in this range.

Runtime considerations

  • 07f075e3 ([PM-42963 ]Retry failed Send deletes so uploads-that-fail don't orphan a Send sdk-internal#1458) changes SendClient::delete to queue failed deletes into a durable pending_send_deletions setting, and adds SendClient::retry_pending_deletions(). Not reachable from Android — the impl block is #[cfg_attr(feature = "wasm", wasm_bindgen)] only (no uniffi export), and Android deletes Sends through its own Retrofit layer (network/…/SendsServiceImpl.kt:135 via SendManagerImpl.deleteSend). Android's SDK Send usage is encrypt/decrypt only (VaultSdkSourceImpl.kt:245-380). Worth noting for later: if Android ever adopts the SDK delete path, it will need a client-managed SettingItem repository registered, or .setting(PENDING_SEND_DELETIONS) will error.
  • The policy-data discriminant changed from type to _policyType in the same commit. Wire/serialization-facing only, and Android doesn't consume PolicyDataType — no impact today.

Everything else in range — confirmed safe

  • e56c2815 (Extract AnyMap from the state registry sdk-internal#1454) — extracts AnyMap from StateRegistry. Purely internal refactor; register_client_managed signature and all public bitwarden-state API unchanged. No binding surface.
  • 07f075e3 — see above; additive to the wasm surface, no uniffi export, no Android call site. Its register_setting_key! macro invocation expands to a plain const Key<T> (bitwarden-state/src/settings/key.rs:27) — no hidden binding surface.
  • dac9ec1a — the rest of the policy-model split (new …PolicyData structs, policies.rs broken into modules) is additive; PolicyType variants unchanged.

Commit

No commit — nothing needed fixing.


  • Gather PR context (old → new SDK version)
  • Enumerate sdk-internal commit range
  • Identify public API / behavioral changes
  • Map changed symbols to Android call sites
  • Report findings
    · branch sdlc/sdk-update

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.39%. Comparing base (d4651f2) to head (f12e52d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7365      +/-   ##
==========================================
- Coverage   86.44%   85.39%   -1.06%     
==========================================
  Files         927      917      -10     
  Lines       67101    66911     -190     
  Branches    10182    10181       -1     
==========================================
- Hits        58006    57136     -870     
- Misses       5516     6197     +681     
+ Partials     3579     3578       -1     
Flag Coverage Δ
app-data 18.39% <ø> (+0.34%) ⬆️
app-ui-auth-tools 18.74% <ø> (+0.11%) ⬆️
app-ui-platform 16.29% <ø> (+<0.01%) ⬆️
app-ui-vault 27.07% <ø> (-0.65%) ⬇️
authenticator 6.04% <ø> (ø)
lib-core-network-bridge 4.06% <ø> (ø)
lib-data-ui 1.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bw-ghapp bw-ghapp Bot changed the title Update SDK to 3.0.0-8715-07f075e3 Update SDK to 3.0.0-8717-e56c2815 Sep 9, 2026
@bw-ghapp bw-ghapp Bot changed the title Update SDK to 3.0.0-8717-e56c2815 Update SDK to 3.0.0-8736-dac9ec1a Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context automated-pr PR created by workflow or other automation t:deps Change Type - Dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants