Skip to content

[PM-32808] feat: Add Add/Edit support for Driver's License item type#6908

Draft
SaintPatrck wants to merge 1 commit into
new-item-types/PM-32808_drivers-licensefrom
new-item-types/PM-32808_drivers-license-add-edit
Draft

[PM-32808] feat: Add Add/Edit support for Driver's License item type#6908
SaintPatrck wants to merge 1 commit into
new-item-types/PM-32808_drivers-licensefrom
new-item-types/PM-32808_drivers-license-add-edit

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck commented May 11, 2026

🎟️ Tracking

📔 Objective

Adds the Add/Edit form for the Driver's License cipher type so users can create new licenses and edit existing ones. Renders editable fields for first / middle / last name, license number (sensitive with show/hide), issuing country, issuing state / province, issuing authority, and license class. Date fields (date of birth, issue date, expiration date) appear as read-only chevron rows pending the native Material date-picker integration, which is tracked separately.

📸 Screenshots

@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 11, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

Reviewed the Add/Edit form for the Driver's License cipher type: new vaultAddEditDriversLicenseItems Compose function, VaultAddEditDriversLicenseTypeHandlers, the matching VaultAddEditAction.ItemType.DriversLicenseType action hierarchy, view-model wiring (handleDriversLicenseTypeActions + updateDriversLicenseContent), and the new VaultAddEditDriversLicenseTypeItemActions test class. The feature follows the established Bank Account / Identity / Card patterns and tests cover all eight new text-change actions. One blocking issue prevents the Android build from compiling.

Code Review Details
  • ❌ : Unresolved Git merge conflict markers committed in strings.xml will break the Android resource build
    • ui/src/main/res/values/strings.xml:1360-1364 (existing unresolved review thread)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 25.90674% with 143 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.50%. Comparing base (be32994) to head (82a1975).

Files with missing lines Patch % Lines
...feature/addedit/VaultAddEditDriversLicenseItems.kt 0.00% 113 Missing ⚠️
...handlers/VaultAddEditDriversLicenseTypeHandlers.kt 42.85% 24 Missing ⚠️
...i/vault/feature/addedit/VaultAddEditItemContent.kt 0.00% 4 Missing ⚠️
.../ui/vault/feature/addedit/VaultAddEditViewModel.kt 93.54% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           new-item-types/PM-32808_drivers-license    #6908      +/-   ##
===========================================================================
- Coverage                                    85.63%   85.50%   -0.13%     
===========================================================================
  Files                                          855      857       +2     
  Lines                                        61270    61421     +151     
  Branches                                      8926     8937      +11     
===========================================================================
+ Hits                                         52466    52516      +50     
- Misses                                        5744     5843      +99     
- Partials                                      3060     3062       +2     
Flag Coverage Δ
app-data 17.36% <0.00%> (-0.06%) ⬇️
app-ui-auth-tools 19.63% <0.00%> (-0.07%) ⬇️
app-ui-platform 15.51% <0.00%> (-0.06%) ⬇️
app-ui-vault 26.58% <25.90%> (-0.01%) ⬇️
authenticator 6.40% <0.00%> (-0.02%) ⬇️
lib-core-network-bridge 4.13% <0.00%> (-0.01%) ⬇️
lib-data-ui 1.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck force-pushed the new-item-types/PM-32808_drivers-license branch from be32994 to 7e3c779 Compare May 11, 2026 21:16
@SaintPatrck SaintPatrck force-pushed the new-item-types/PM-32808_drivers-license-add-edit branch from 82a1975 to 1eeba27 Compare May 11, 2026 21:20
Comment on lines +1360 to +1364
<<<<<<< HEAD
<string name="license_details">License details</string>
=======
<string name="drivers_license_details">License details</string>
>>>>>>> 82a197596 ([PM-32808] feat: Add Add/Edit support for Driver's License item type)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Unresolved Git merge conflict markers committed in strings.xml.

Details and fix

Lines 1360–1364 contain literal <<<<<<< HEAD, =======, and >>>>>>> 82a197596 ... conflict markers. These are not valid XML, so aapt2 will fail to compile the resources and the Android build will not succeed.

The base branch (new-item-types/PM-32808_drivers-license) already defines license_details, and both VaultItemDriversLicenseContent.kt and the new VaultAddEditDriversLicenseItems.kt reference BitwardenString.license_details. The "HEAD" side of the conflict is the correct resolution; the drivers_license_details duplicate from the incoming side should be discarded.

Suggested resolution:

Suggested change
<<<<<<< HEAD
<string name="license_details">License details</string>
=======
<string name="drivers_license_details">License details</string>
>>>>>>> 82a197596 ([PM-32808] feat: Add Add/Edit support for Driver's License item type)
<string name="license_details">License details</string>
</resources>

After applying, run a quick local build (./gradlew app:assembleStandardDebug or equivalent) to confirm resources compile.

@SaintPatrck SaintPatrck force-pushed the new-item-types/PM-32808_drivers-license branch from 7e3c779 to 1bc6a61 Compare May 11, 2026 21:30
@SaintPatrck SaintPatrck force-pushed the new-item-types/PM-32808_drivers-license-add-edit branch from 1eeba27 to d4c07be Compare May 12, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant