Repository navigation
fix(tests): fail-soft live-Core probe when no checkout is present - #11
Merged
Merged
Conversation
The plugins CI job (bitty-terminal/bitty-plugins#73) has no bitty Core alongside. Every parity row runs hermetic against the SDK mock (Core cited at bitty@1df0459e, never read from disk), but add an explicit fail-soft probe resolving Core via BITTY_WORKSPACE/relative fallback (never a hardcoded path): skip with a printed notice when absent, execute when present. ALL mock assertions keep running. Evidence: BITTY_WORKSPACE=/tmp/nonexistent-bitty-workspace bun test -> 52 pass, 1 skip; BITTY_WORKSPACE=$BITTY_WORKSPACE bun test -> 53 pass. just check green both modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority: P1 | Area: architecture | Labels: bug,P1,area:architecture | Milestone: v0.1.0 | Task: cmd-fix-live-skip-ci
Unblocks bitty-terminal/bitty-plugins#73: the plugins CI job has no bitty Core alongside. Every parity row in tests/verify-parity.test.ts runs hermetic against the SDK mock (Core cited at bitty@1df0459e, never read from disk), but it had no explicit fail-soft gate.
Skip semantics: add a fail-soft probe resolving Core via BITTY_WORKSPACE/relative fallback (never a hardcoded path) with fresh origin/main read-only plumbing for crates/bitty-terminal/src/editor_host.rs. The probe uses the curried bun API describe.skipIf(!CORE_PRESENT)(...) and prints an explicit console notice when skipping (not silent); ALL 12 mock assertions keep running in both modes. With BITTY_WORKSPACE pointed at a real workspace the probe executes (proves the skip never masks a real run).
Evidence (worktree cmd/fix-live-skip-ci, commit 4627576, base origin/main d7d39df):
Scope: tests/verify-parity.test.ts only (imports + helpers + 1 probe). No lua/, no manifest.
Do NOT merge (per task; awaiting review + CI).