[CTX-0022] fix(registry): batch 1 - entry types, URL identity, SPDX validation - #57
Merged
Merged
Conversation
…alidation Implements three registry validation fixes (PLUG-REG-001, PLUG-REG-004, PLUG-REG-014): 1. validateRawEntryTypes() - Pre-normalization type validation (#48) - Validates field types before normalization to prevent silent coercion - Reports wrong types as errors rather than defaulting - Covers all required, optional, array, object, and nested fields 2. parseRepositoryIdentity() - Centralized URL parsing (#51) - Extracts owner, repo, fullPath, and host from repository URLs - Preserves nested namespaces (e.g., gitlab.com/group/subgroup/repo) - Used by rawManifestUrl() and repositoryName() for consistency 3. SPDX expression validation - Balanced parentheses (#54) - Validates parentheses balance before tokenization - Tokenizes expressions preserving parentheses as separate tokens - Handles complex expressions: (MIT OR Apache-2.0) AND BSD-3-Clause All fixes include comprehensive test coverage. Closes #48, #51, #54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements three registry validation fixes (PLUG-REG-001, PLUG-REG-004, PLUG-REG-014):
Changes
1. validateRawEntryTypes() - Pre-normalization type validation (#48)
2. parseRepositoryIdentity() - Centralized URL parsing (#51)
3. SPDX expression validation - Balanced parentheses (#54)
Testing
All fixes include comprehensive test coverage (113 tests passing).
Quality Gates
Priority: P2 | Area: plugins | Labels: fix, P2, area:plugins | Milestone: v0.1.0 | Task: CTX-0022
Closes #48
Closes #51
Closes #54