Fix LDAP_ACCESSLOG_ADMIN_PASSWORD variable assignment#94986
Open
vermiceli wants to merge 4 commits into
Open
Conversation
The README specifies `LDAP_ACCESSLOG_ADMIN_PASSWORD` as the variable controlling admin access to the accesslog database, but the script is sourcing the value from `LDAP_ACCESSLOG_PASSWORD`. This change makes the assignment consistent with all other variables in this block, and match the documentation. Signed-off-by: Michael Miceli <michael.miceli88@gmail.com>
Signed-off-by: Michael Miceli <michael.miceli88@gmail.com>
Signed-off-by: Michael Miceli <michael.miceli88@gmail.com>
Updated documentation to match environment variable default changes introduced in 3edc868 Signed-off-by: Michael Miceli <michael.miceli88@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README specifies
LDAP_ACCESSLOG_ADMIN_PASSWORDas the variable controlling admin access to the accesslog database, but the script is sourcing the value fromLDAP_ACCESSLOG_PASSWORD. This change makes the assignment consistent with all other variables in this block, and match the documentation.It seems that the environment variable name was always a mistake since it was added, but in 3edc868 the default value was removed and a check was added for when the value is empty.
Finally, 3edc868 either changed the default or removed the default for a few environment variables. I've updated the README to reflect these new defaults (or lack thereof).