Repository navigation
feat(person-twin): compose guarded R21H FAST evidence - #211
Merged
Merged
Conversation
Compose R2 and R4 with a pinned CURRENT snapshot and repeat validation before model prompt construction. Preserve generic runtime/DeepLite behavior and reject protected fallback and nested dispatch. Publish the user-approved tree 1d97123 from reviewed local candidate f87f9e496088347b314cf731b4170a9ad8d51b8d. Local synthetic qualification: 154 scoped tests passed with zero socket events observed. Draft review scope only. Trusted host/provider/intent inputs remain a precondition; no production admission, real personal-data ingestion or native H3 qualification.
Resolve the unchanged adjacent R4 fixture by file path instead of a bare module import so pytest importlib mode can collect the R21H adapter tests outside the source checkout. Preserve runtime, adapter, fixture and CI bytes. Document initial PR #211 wheel-collection failures and local verification: 154 scoped tests, 61 standalone importlib tests, and actual installed-wheel gate 2407 passed / 117 skipped / 870 subtests passed. Reviewed local candidate 81ccd745886a6a23b559029515b84f832426379c; exact tree 3ed09df. Synthetic qualification only; no production/native admission.
This was referenced Oct 13, 2026
Merged
bitmaster162
marked this pull request as ready for review
October 15, 2026 15:14
bitmaster162
added a commit
that referenced
this pull request
Oct 20, 2026
…able-demo-r2 feat(person-twin): durable admission + no-sidecar continuity demo (on master after #211)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The optional Person evidence path composes the existing R21H runtime with R2 privacy/provenance and R4 READ authorization. Post-CI review found that a bound cold-streaming helper could reenter an active request and send the same prompt twice. The request-phase followup closes that concrete sequencing defect.
Current revision
Reviewed source tree: fcb37ef8d9af2c349a62c576b5634798881a7fbe.
Reviewed local candidate: 7e491fe5ce233a93489f0a622f8969e8bfa94fba.
The followup is bound to sole parent 742c7aa and the exact reviewed tree. Connector metadata may produce a different commit SHA; these unsigned commits are not an owner-signoff receipt.
Cumulative scope against master 719ed32: four commits, six files, 2850 additions / 0 deletions. This followup changes only the R21H runtime, its Person integration tests and the existing integration document: 179 additions / 3 deletions.
Resulting behavior
Request-phase evidence
The published predecessor 742c7aa / tree 3ed09df had five successful GitHub checks, but they did not cover the newly found reentry. Local characterization of those exact runtime bytes captured two streaming calls with identical prompts, three provider reads and an outer ALLOW receipt. Twelve new regression cases failed on that predecessor as expected; six demonstrated an extra transport call, and six demonstrated missing prompt/evidence phase rejection.
On the corrected source, the local scoped run passed 166 tests with zero failures or skips: 73 Person/R21H integration cases, 50 unchanged R4 cases and 43 existing runtime/DeepLite cases. A separate reviewer replayed the same twelve regressions in importlib mode: 12 passed, zero failures or skips. Socket events were denied and zero were observed; the five selected code/test hashes were identical before and after each run.
Independent source review passed on runtime SHA-256 8ce39204994fa7d8d622246cb4a766547980bf5ff5c89163eeb479dbbaafd935 and test SHA-256 eecf6b2b86974e2a7ebaaa9223e79b7a57cc929d5dc5fa9edbc7eaebdd83cc19. Reviews and local runs share the repository/fixture lineage; they are not independent owner authority. GitHub CI for this new HEAD must be observed separately from the predecessor and local runs.
Preserved validation history
The initial 4d8cf5d / tree 1d97123f candidate passed its clean-source suites but failed installed-wheel collection in run 38296546803 because of a bare sibling-fixture import. The followup at 742c7aa fixed that import without changing runtime, R4 or CI tools. Its run 38298448627 subsequently passed both platforms, including installed-wheel suites (Ubuntu 2407 passed / 117 skipped; Windows 2408 passed / 116 skipped; each 870 passed subtests). Those results remain scoped to that predecessor.
The earlier no-blockers review conclusion is superseded for the newly characterized request-reentry path; this followup and its regression results address that path explicitly.
Acceptance limits
Synthetic data and recording fake model clients only. The host, intent issuer, provider and transport remain trusted integration inputs. This in-process phase guard does not provide source-origin/time/egress authentication, durable cross-request replay protection, atomic admission/SQLite/model delivery, native H3 or full P3 admission. No CLI/API/MCP enablement or production qualification.
C0 HOLD; T11/T12 UNEXECUTED; NOT_PRODUCTION_ADMITTED. Related: #144. This does not close #144, merge or close #150, change #209/#210, or authorize merge/deployment/personal-data ingestion.