fix(registry): move instance lock outside data dir for Windows remove - #332
Merged
Conversation
Windows cannot unlink state.json.lock while remove still holds the open handle; keep the lock at .locks/<name>.lock so Delete can RemoveAll safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localnet removefailing onstate.json.lock(“file is being used by another process”) by moving the per-instance lock to.locks/<name>.lockunder the registry root (#331).Test plan
go test ./internal/registry/ ./internal/localnet/ -count=1localnet up localnet-1thenlocalnet remove localnet-1(or--force) completes without the lock unlink errorlocalnet listno longer shows the instance