Repository navigation
Exclude ch34x_driver.cpp from coverage - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/drivers/ch34x/ch34x_driver.cppis the CH340 counterpart offtdi_driver.cpp: it is the code that actually talks to a device over libusb,so the unit tests cannot reach it without hardware.
ftdi_driver.cppwas alreadyexcluded for that reason; this adds the CH340 one on the same grounds.
Merging the ch340 driver dropped the reported figure from 85.0% to 75.1%, against
a
--fail-under-line 75gate — it passed with 0.1 points to spare, and the nextchip family would have tripped it. The number was measuring how much untestable
transport code the tree contains rather than how well the testable code is
covered.
The scope comment is reworded to say the rule rather than list the files, since
every new chip family adds one more driver to it.