Us the same link instance in send_packet() - #607
Open
ArisMorgens wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When flashing a Crazyflie 2.0 via cfclient, most of the times the process got stuck in "identifying decks to update", with this error:
This was caused by
send_packet()readingself.linktwice: first inif self.link is not None:, and then inelf.link.send_packet(pk). Between these reads, other threads (e.g.close_link()) can set the link toNone.This PR fixes that by reading self.link only once, so the commands in
send_packet()will always agree.