Skip to content

fix(core,chain): disable serde default features for no_std #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ANAMASGARD wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(core,chain): disable serde default features for no_std #2238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a11bc4a
fix(core,chain): disable serde default features for no_std
ANAMASGARD Jul 7, 2026
d513733
Merge branch 'master' into fix/2208-serde-no-std-default-features
ANAMASGARD Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/cont_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,30 @@ jobs:
defaults:
run:
working-directory: ./crates/chain
# TODO "--target thumbv6m-none-eabi" should work but currently does not
run: cargo check --no-default-features --features hashbrown
- name: Check serde does not enable serde/std in no_std builds
run: |
set -euo pipefail
check_no_serde_std() {
local pkg="$1" features="$2"
if cargo tree -p "$pkg" -e features \
--no-default-features --features "$features" --no-dev-dependencies \
| grep -q 'serde feature "std"'; then
echo "error: serde/std enabled for $pkg with features=$features"
exit 1
fi
}
check_no_serde_std bdk_core serde
check_no_serde_std bdk_chain serde
- name: Install ARM cross-compiler
run: sudo apt-get update && sudo apt-get install -y gcc-arm-none-eabi
- name: Add bare-metal target
run: rustup target add thumbv7em-none-eabihf
- name: Check bdk_chain serde on bare-metal target
working-directory: ./crates/chain
run: cargo check --no-default-features --features serde --target thumbv7em-none-eabihf
- name: Check esplora
steps:
- name: Checkout
uses: actions/checkout@v6
Expand Down
4 changes: 2 additions & 2 deletions crates/chain/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ workspace = true
[dependencies]
bitcoin = { version = "0.32.0", default-features = false }
bdk_core = { path = "../core", version = "0.6.2", default-features = false }
serde = { version = "1", optional = true, features = ["derive", "rc"] }
serde = { version = "1", optional = true, default-features = false, features = ["derive", "rc", "alloc"] }
miniscript = { version = "13.0.0", optional = true, default-features = false }

# Feature dependencies
Expand All @@ -32,7 +32,7 @@ criterion = { version = "0.7" }

[features]
default = ["std", "miniscript"]
std = ["bitcoin/std", "miniscript?/std", "bdk_core/std"]
std = ["bitcoin/std", "miniscript?/std", "bdk_core/std", "serde?/std"]
serde = ["dep:serde", "bitcoin/serde", "miniscript?/serde", "bdk_core/serde"]
hashbrown = ["bdk_core/hashbrown"]
rusqlite = ["std", "dep:rusqlite", "serde"]
Expand Down
4 changes: 2 additions & 2 deletions crates/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ readme = "README.md"

[dependencies]
bitcoin = { version = "0.32", default-features = false }
serde = { version = "1", optional = true, features = ["derive", "rc"] }
serde = { version = "1", optional = true, default-features = false, features = ["derive", "rc", "alloc"] }
hashbrown = { version = "0.14.5", optional = true, default-features = false, features = ["ahash", "inline-more"] }

[features]
default = ["std"]
std = ["bitcoin/std"]
std = ["bitcoin/std", "serde?/std"]
serde = ["dep:serde", "bitcoin/serde", "hashbrown?/serde"]

[dev-dependencies]
Expand Down