ci: individual package tests#2209
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2209 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 30 30
Lines 5934 5934
Branches 281 281
=======================================
Hits 4648 4648
Misses 1210 1210
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ValuedMammal
added
the
github_actions
ValuedMammal
force-pushed
the
update_ci
branch
2 times, most recently
from
adeded1 to
06a3fe4
Compare
Collaborator
Author
|
Added workspace level MSRV job. Added per-crate jobs to build meaningful feature combinations and test all features. Removed build-test job.
Collaborator
Author
|
Rebased |
Comment on lines
+266
to
+286
| check-no-std: | ||
| needs: prepare | ||
| name: Check no-std | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| toolchain: ${{ needs.prepare.outputs.rust_version }} | ||
| cache: true | ||
| # TODO: `--target thumbv6m-none-eabi` should work but currently does not | ||
| # target: thumbv6m-none-eabi | ||
| - name: Check bdk_core (no-std, hashbrown) | ||
| working-directory: ./crates/core | ||
| run: cargo check --no-default-features --features hashbrown | ||
| - name: Check bdk_chain (no-std, hashbrown + miniscript) | ||
| working-directory: ./crates/chain | ||
| run: cargo check --no-default-features --features hashbrown,miniscript |
Collaborator
There was a problem hiding this comment.
nit: As you've splitted into multiple jobs, it could live in each one of them. Unless, you're looking forward to keep this one as the one that uses an specific target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1944
Description
Replaces the monolithic
build-testmatrix job (which ran a 2-toolchain × 2-feature-set matrix across the whole workspace) with dedicated per-crate build jobs. Each crate uses named steps for every meaningful feature combination, making it easy to identify which specific crate and feature set broke in CI.Changes:
build-core,build-chain,build-bitcoind-rpc,build-electrum,build-esplora,build-file-store,build-testenv— each with per-featurecargo buildsteps and acargo test --all-featuresstepmsrvjob: Simplified from a matrix to a single flat job targeting 1.85.0; runscargo build --workspace --all-targetsandcargo test --workspace --lib --tests --all-featurescheck-no-std: Updated to checkbdk_coreandbdk_chainwith no default features + withhashbrownandminiscript; cross-compilation againstthumbv6m-none-eabiis stubbed out as usual to be addressed in a separate PR