chore: make justfile fully compatible with Windows/PowerShell by MusabYK · Pull Request #100 · bitcoindevkit/bdk-dart

MusabYK · 2026-06-27T12:38:32Z

Description

This PR addresses #97 #98 and several platform-specific compatibility bugs in the justfile. Running certain recipes natively on Windows (via PowerShell) caused execution panics or syntax errors due to hardcoded Unix commands (rm -rf, open) and bash-specific operators (&&).

Changes Implemented

set unstable := true: Allow experimental features like [group(...)]
set shell := ["sh", "-c"]: Default shell for Mac and Linux
set windows-shell := ["powershell.exe", "-Command"] Specific override ONLY for Windows users
generate-bindings: Fixed a crash where bash was explicitly invoked. Refactored it to conditionally cd into native and invoke the windows specific binding generation commands to correctly generate bindings for bdk_dart_ffi.dll.
clean: Conditionally swapped Unix rm -rf for PowerShell's native Remove-Item -Recurse -Force when executing on a windows host, preventing command parsing failures.
repo: Conditionally replaced the open command with Windows Start-Process for launching the GitHub repository in the default browser.
demo-analyze & demo-test: Conditionally replaced the chaining operator && with the PowerShell's separator ; for Windows environments.

Investigation & findings

After fixing the Justfile to support Windows, I ran the just ci command, the project builds and the test suite starts successfully, but when the just ci reaches demo-test several demo tests fail with the following error.

Error:

PathAccessException: Deletion failed, path = 'C:\Users...\wallet_service_test_xxxxx'
(OS Error: The process cannot access the file because it is being used by another process, errno = 32)
dart:io FileSystemEntity.delete
package:bdk_demo/core/utils/wallet_storage_paths.dart 57:17 WalletStoragePaths.deleteFallbackWalletData
package:bdk_demo/services/wallet_service.dart 617:32 WalletService._reseedWalletToFallbackSqlite

Recommendation

The PathAccessException error should be addressed through a separate PR, once its fixed, the just ci should pass on Windows just as it does on Linux and macOS.

j-kon

Thanks for taking this on, @MusabYK. This is a helpful improvement for Windows contributors, and I like that the scope stays focused on the Justfile.

I was not able to run just locally on my machine because it is not installed here, so one thing I would like to confirm before this is merged: have you tested the updated recipes on Windows/PowerShell, especially just list, just format, just clean, and just generate-bindings?

If those pass on Windows, this looks aligned with #97 and #98 to me.

j-kon · 2026-06-29T09:16:03Z

 generate-bindings:
-  bash ./scripts/generate_bindings.sh
+  {{ if os() == "windows" {
+        "cd native; cargo build --profile dev; cargo run --profile dev --bin uniffi-bindgen -- generate --library target\\debug\\bdk_dart_ffi.dll --language dart --config uniffi.toml --out-dir ..\\lib\\"


Small behavior note: PowerShell ; always runs the next command, so if cd native or cargo build fails, the following command can still run. Could we keep this fail-fast like the original script behavior?

Yeah, great point I'll look into fixing that.

j-kon · 2026-06-29T09:16:03Z

+  {{ if os() == "windows" {
+     "Start-Process https://github.com/bitcoindevkit/bdk-dart" 
+    } else {
+     "open https://github.com/bitcoindevkit/bdk-dart" 


Small cross-platform note: this still uses macOS open for every non-Windows OS. Since this PR is improving cross-platform Justfile support, should we use xdg-open on Linux and keep open only for macOS?

Thats a good idea, i assumed the current justfile support Linux as well, I just test all the just commands on my WSL, they all passed except the just repo command.
I'll look into that as well. Thanks!

- Replace manual directory switching with native '[working-directory]' attribute. - Add fail-fast error checking ('if (-not $?)') to Windows bindings generation. - Standardize Windows file paths to use forward slashes.

MusabYK · 2026-06-29T22:57:30Z

Hi @j-kon I have applied the requested changes and refactored the justfile:

Added Linux compatibility to just repo using xdg-open.
Replaced manual cd commands with the native [working-directory] attribute for the demo tasks.
Standardised the paths with forward slashes and added fail-fast checks to the bindings generation script,
Let me know if there is anything else to adjust

j-kon · 2026-06-30T03:33:04Z

Thanks @MusabYK, I checked the latest update and the two review points look addressed now.

The repo recipe now handles Linux with xdg-open, while keeping macOS/Windows separate, and the Windows generate-bindings path now has fail-fast checks after the key steps. Nice cleanup with the [working-directory] refactor too.

reez · 2026-06-30T13:11:37Z

 [doc("Build native library and regenerate bindings.")]
 generate-bindings:
-  bash ./scripts/generate_bindings.sh
+  {{ if os() == "windows" {


This multi-line interpolation has the same parser issue as the generate-bindings recipe: just --list --unsorted fails with error: Unterminated interpolation before any recipe can run.

I pushed the requested fix now.

Johnosezele

utACK on this one, we'd need someone to run this on Windows to confirm it matches what we expect.

Johnosezele · 2026-07-06T19:27:31Z

+
+unix_clean := "rm -rf .dart_tool/ build/ native/target/ coverage/ bdk_demo/.dart_tool/ bdk_demo/build/ example/.dart_tool/ example/build/"
+
+opener := if os_family() == "windows" { "Start-Process" } else if os() == "macos" { "open" } else { "xdg-open" }


small nit here: repo uses os_family() but bindings use os(). Probably fine, but worth picking one and sticking with it.

Johnosezele · 2026-07-06T19:27:51Z

+
+set windows-shell := ["powershell.exe", "-Command"]
+
+windows_generate_bindings := "cd native; if (-not $?) { exit 1 }; cargo build --profile dev; if (-not $?) { exit 1 }; cargo run --profile dev --bin uniffi-bindgen -- generate --library target/debug/bdk_dart_ffi.dll --language dart --config uniffi.toml --out-dir ../lib/"


The Windows path skips dart pub get from the bash script. Is that intentional?

Absolutely not. Thanks for checking and pointing it out.

Ugarba202 · 2026-07-07T16:56:33Z

ACK 0822dce
Thanks for updating this, @MusabYK I reviewed the latest changes and confirmed that dart pub get is restored in the Windows bindings recipe and os() is used consistently now.
I tested the recipes locally on my end and everything parses and runs cleanly without any regressions. Looks good to me!

Johnosezele · 2026-07-14T06:33:00Z

I'd need one more tACK here from a windows OS user before letting this in.

Ugarba202 · 2026-07-14T07:54:08Z

I'd need one more tACK here from a windows OS user before letting this in.

Thanks for the update. Sounds good, I'll hold tight for a Windows tester to take a look.

reez · 2026-07-20T11:35:38Z

The OS dispatch and Windows binding command look reasonable, and the four affected recipes passed on macOS with just 1.57.0.

John is right on us needing another windows user tACK to make sure we get more testers.

One question I have too is the Windows CI job does not execute just, so the requested native Windows/PowerShell validation remains outstanding.

Also, [working-directory] raises the undocumented minimum just version to 1.38.0 and makes older versions reject the entire file, so not sure if the plan is to document/test that requirement or avoid the attribute.

MusabYK · 2026-07-20T13:42:08Z

Though not sure how long that's gonna take but it will be nice getting another Windows tACK to confirm across different environments.
On the [working-directory] feat I prefer keeping the justfile clean and using modern features, we can keep the attribute and update the CONTRIBUTION.md to note that just >= 1.38.0 is required.

chore: make justfile fully compatible with Windows/PowerShell

f0ede1e

MusabYK mentioned this pull request Jun 27, 2026

Support seamless cross-platform Justfile execution across Windows #97

Open

j-kon reviewed Jun 29, 2026

View reviewed changes

Fix: Add Linux support to 'repo' recipe using xdg-open.

cd8c706

- Replace manual directory switching with native '[working-directory]' attribute. - Add fail-fast error checking ('if (-not $?)') to Windows bindings generation. - Standardize Windows file paths to use forward slashes.

reez reviewed Jun 30, 2026

View reviewed changes

fix(justfile): replace multi-line interpolations with variables

cc2505c

This was linked to issues Jul 2, 2026

fix: generate-bindings fails on Windows #98

Open

Support seamless cross-platform Justfile execution across Windows #97

Open

Johnosezele requested changes Jul 6, 2026

View reviewed changes

add dart pub get to windows_generate_bindings

0822dce

Ugarba202 mentioned this pull request Jul 9, 2026

fix(demo): dispose sqlite persister before folder rename in wallet service #112

Merged


		unix_clean := "rm -rf .dart_tool/ build/ native/target/ coverage/ bdk_demo/.dart_tool/ bdk_demo/build/ example/.dart_tool/ example/build/"

		opener := if os_family() == "windows" { "Start-Process" } else if os() == "macos" { "open" } else { "xdg-open" }


		set windows-shell := ["powershell.exe", "-Command"]

		windows_generate_bindings := "cd native; if (-not $?) { exit 1 }; cargo build --profile dev; if (-not $?) { exit 1 }; cargo run --profile dev --bin uniffi-bindgen -- generate --library target/debug/bdk_dart_ffi.dll --language dart --config uniffi.toml --out-dir ../lib/"

Uh oh!

Conversation

MusabYK commented Jun 27, 2026

Description

Changes Implemented

Investigation & findings

Error:

Recommendation

Uh oh!

j-kon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MusabYK commented Jun 29, 2026

Uh oh!

j-kon commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Johnosezele left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ugarba202 commented Jul 7, 2026

Uh oh!

Johnosezele commented Jul 14, 2026

Uh oh!

Ugarba202 commented Jul 14, 2026

Uh oh!

reez commented Jul 20, 2026

Uh oh!

MusabYK commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

j-kon commented Jun 30, 2026 •

edited

Loading

MusabYK commented Jul 20, 2026 •

edited

Loading