bip-0352: do not require the optional expected argument - #2279
Open
fametrano wants to merge 1 commit into
Open
Conversation
create_outputs and scanning declare expected with a default of None but dereference it unconditionally (expected.get(...)), so calling either without it raises AttributeError, although the parameter is documented optional. Guard the expected-value checks with `if expected is not None:`. The self-test, which always passes expected, is unaffected.
murchandamus
added
Proposed BIP modification
Member
|
cc: @theStack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_outputsandscanningdeclareexpectedwith a default ofNonebut dereferenceexpected.get(...)unconditionally, so calling either without it raisesAttributeError, although the parameter is documented optional.Guard the expected-value checks with
if expected is not None:. The self-test, which always passesexpected, is unaffected; a standalone call withexpected=Nonenow returns its result instead of raising.If the harness coupling is intentional, I am happy to close this or turn it into a docs note instead.