Skip to content

refactor: Add more MAYBE_UNUSED annotations #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fanquake wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Add more MAYBE_UNUSED annotations #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009b9dd
Remove unused arguments from Run()
fanquake Sep 7, 2026
8f99761
Add MAYBE_UNUSED to ConstructGeneric*, ConstructClMul*, ConstructClM…
fanquake Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/fields/clmul_1byte.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -82,7 +83,7 @@ typedef Field<uint8_t, 8, 27, StatTable8, &SQR_TABLE_8, &SQR2_TABLE_8, &QRT_TABL
#endif
}

Sketch* ConstructClMul1Byte(int bits, int implementation) {
Sketch* ConstructClMul1Byte(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_5
case 5: return new SketchImpl<Field5>(implementation, 5);
Expand All @@ -94,7 +95,7 @@ Sketch* ConstructClMul1Byte(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri1Byte(int bits, int implementation) {
Sketch* ConstructClMulTri1Byte(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_2
case 2: return new SketchImpl<FieldTri2>(implementation, 2);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_2bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -105,7 +106,7 @@ typedef Field<uint16_t, 16, 43, StatTable16, &SQR_TABLE_16, &SQR2_TABLE_16, &SQR
#endif
}

Sketch* ConstructClMul2Bytes(int bits, int implementation) {
Sketch* ConstructClMul2Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_10
case 10: return new SketchImpl<Field10>(implementation, 10);
Expand All @@ -129,7 +130,7 @@ Sketch* ConstructClMul2Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri2Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri2Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_9
case 9: return new SketchImpl<FieldTri9>(implementation, 9);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_3bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -114,7 +115,7 @@ typedef Field<uint32_t, 24, 27, StatTable24, &SQR_TABLE_24, &SQR2_TABLE_24, &SQR
#endif
}

Sketch* ConstructClMul3Bytes(int bits, int implementation) {
Sketch* ConstructClMul3Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_17
case 17: return new SketchImpl<Field17>(implementation, 17);
Expand All @@ -141,7 +142,7 @@ Sketch* ConstructClMul3Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri3Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri3Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_17
case 17: return new SketchImpl<FieldTri17>(implementation, 17);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_4bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -112,7 +113,7 @@ typedef Field<uint32_t, 32, 141, StatTable32, &SQR_TABLE_32, &SQR2_TABLE_32, &SQ
#endif
}

Sketch* ConstructClMul4Bytes(int bits, int implementation) {
Sketch* ConstructClMul4Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_25
case 25: return new SketchImpl<Field25>(implementation, 25);
Expand All @@ -136,7 +137,7 @@ Sketch* ConstructClMul4Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri4Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri4Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_25
case 25: return new SketchImpl<FieldTri25>(implementation, 25);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_5bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -122,7 +123,7 @@ typedef Field<uint64_t, 40, 57, StatTable40, &SQR_TABLE_40, &SQR2_TABLE_40, &SQR
#endif
}

Sketch* ConstructClMul5Bytes(int bits, int implementation) {
Sketch* ConstructClMul5Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_33
case 33: return new SketchImpl<Field33>(implementation, 33);
Expand Down Expand Up @@ -152,7 +153,7 @@ Sketch* ConstructClMul5Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri5Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri5Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_33
case 33: return new SketchImpl<FieldTri33>(implementation, 33);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_6bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -121,7 +122,7 @@ typedef Field<uint64_t, 48, 45, StatTable48, &SQR_TABLE_48, &SQR2_TABLE_48, &SQR
#endif
}

Sketch* ConstructClMul6Bytes(int bits, int implementation) {
Sketch* ConstructClMul6Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_41
case 41: return new SketchImpl<Field41>(implementation, 41);
Expand All @@ -148,7 +149,7 @@ Sketch* ConstructClMul6Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri6Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri6Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_41
case 41: return new SketchImpl<FieldTri41>(implementation, 41);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_7bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -121,7 +122,7 @@ typedef Field<uint64_t, 56, 149, StatTable56, &SQR_TABLE_56, &SQR2_TABLE_56, &SQ
#endif
}

Sketch* ConstructClMul7Bytes(int bits, int implementation) {
Sketch* ConstructClMul7Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_49
case 49: return new SketchImpl<Field49>(implementation, 49);
Expand Down Expand Up @@ -151,7 +152,7 @@ Sketch* ConstructClMul7Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri7Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri7Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_49
case 49: return new SketchImpl<FieldTri49>(implementation, 49);
Expand Down
5 changes: 3 additions & 2 deletions src/fields/clmul_8bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "../int_utils.h"
#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -129,7 +130,7 @@ typedef Field<uint64_t, 64, 27, StatTable64, &SQR_TABLE_64, &SQR2_TABLE_64, &SQR
#endif
}

Sketch* ConstructClMul8Bytes(int bits, int implementation) {
Sketch* ConstructClMul8Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_57
case 57: return new SketchImpl<Field57>(implementation, 57);
Expand All @@ -153,7 +154,7 @@ Sketch* ConstructClMul8Bytes(int bits, int implementation) {
return nullptr;
}

Sketch* ConstructClMulTri8Bytes(int bits, int implementation) {
Sketch* ConstructClMulTri8Bytes(int bits, MAYBE_UNUSED int implementation) {
switch (bits) {
#ifdef ENABLE_FIELD_INT_57
case 57: return new SketchImpl<FieldTri57>(implementation, 57);
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_1byte.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -83,7 +84,7 @@ typedef Field<uint8_t, 8, 27, StatTable8, DynTable8, &SQR_TABLE_8, &QRT_TABLE_8>
#endif
}

Sketch* ConstructGeneric1Byte(int bits, int implementation)
Sketch* ConstructGeneric1Byte(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_2
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_2bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint16_t, 16, 43, StatTable16, DynTable16, &SQR_TABLE_16, &QRT_TAB
#endif
}

Sketch* ConstructGeneric2Bytes(int bits, int implementation)
Sketch* ConstructGeneric2Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_9
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_3bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint32_t, 24, 27, StatTable24, DynTable24, &SQR_TABLE_24, &QRT_TAB
#endif
}

Sketch* ConstructGeneric3Bytes(int bits, int implementation)
Sketch* ConstructGeneric3Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_17
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_4bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint32_t, 32, 141, StatTable32, DynTable32, &SQR_TABLE_32, &QRT_TA
#endif
}

Sketch* ConstructGeneric4Bytes(int bits, int implementation)
Sketch* ConstructGeneric4Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_25
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_5bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint64_t, 40, 57, StatTable40, DynTable40, &SQR_TABLE_40, &QRT_TAB
#endif
}

Sketch* ConstructGeneric5Bytes(int bits, int implementation)
Sketch* ConstructGeneric5Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_33
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_6bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint64_t, 48, 45, StatTable48, DynTable48, &SQR_TABLE_48, &QRT_TAB
#endif
}

Sketch* ConstructGeneric6Bytes(int bits, int implementation)
Sketch* ConstructGeneric6Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_41
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_7bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint64_t, 56, 149, StatTable56, DynTable56, &SQR_TABLE_56, &QRT_TA
#endif
}

Sketch* ConstructGeneric7Bytes(int bits, int implementation)
Sketch* ConstructGeneric7Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_49
Expand Down
3 changes: 2 additions & 1 deletion src/fields/generic_8bytes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "../lintrans.h"
#include "../sketch_impl.h"
#include "../util.h"

#endif

Expand Down Expand Up @@ -92,7 +93,7 @@ typedef Field<uint64_t, 64, 27, StatTable64, DynTable64, &SQR_TABLE_64, &QRT_TAB
#endif
}

Sketch* ConstructGeneric8Bytes(int bits, int implementation)
Sketch* ConstructGeneric8Bytes(int bits, MAYBE_UNUSED int implementation)
{
switch (bits) {
#ifdef ENABLE_FIELD_INT_57
Expand Down
2 changes: 1 addition & 1 deletion src/int_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ struct LFSR {
template<typename I, int N, typename L, typename F, int K> struct GFMulHelper;
template<typename I, int N, typename L, typename F> struct GFMulHelper<I, N, L, F, 0>
{
static inline constexpr I Run(const I& a, const I& b) { return I(0); }
static inline constexpr I Run(const I&, const I&) { return I(0); }
};
template<typename I, int N, typename L, typename F, int K> struct GFMulHelper
{
Expand Down
Loading