test: make t0025 and t9018 executable like every other t/ test - #205
Merged
Merged
Conversation
Both were committed as 100644 while the rest of t/*.sh are 100755. t/run-tests.sh chmods a test before running it, so nothing was broken — but the chmod lands on a tracked file, so every run of the suite left a mode change in the working tree. That is easy to sweep into an unrelated commit with `git add -A`; it happened to #201 and had to be stripped back out. The runner keeps its chmod as a safety net. Dropping it would leave a newly added test silently unrun, and invoking tests through `sh` instead would break the ones with a bash shebang. Fixes #203 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDVUJHu38YtVAr6sKZtRDB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203.
Two files were committed as
100644while the rest oft/*.share100755:t/run-tests.shchmods a test before running it, so nothing was broken — but the chmod lands on a tracked file, so every run of the suite left a mode change in the working tree:That is easy to sweep into an unrelated commit with
git add -A. It happened while I was preparing #201 and had to be stripped back out, and it happened again an hour ago when I ran thet0suite to gather data for #204 — which is what prompted the issue.Verification
After the change, running both tests leaves the tree clean:
Every
t/*.shis now100755in the index — checked withgit ls-files -s.What I deliberately left alone
#203 also floated making
run-tests.shsurface a wrong mode rather than silently chmodding. I kept the chmod, on reflection:sh "$test"would sidestep the mode entirely, but the suite mixes#!/bin/shand#!/bin/bashshebangs, so the bash-dependent files would break.The chmod is a reasonable safety net once the committed modes are correct; it simply never fires now.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VDVUJHu38YtVAr6sKZtRDB
Generated by Claude Code