Repository navigation
feat(mac): bundle ffmpeg and ship a drag-to-Applications DMG - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mac users install by dragging the app from a DMG. Nothing else to install: ffmpeg ships inside the app.
ffmpeg build:
--disable-gpl --disable-autodetect --enable-securetransport --enable-zlib --disable-encoders --disable-avdevice --disable-x86asm. The recorder only stream-copies. It links onlylibSystem,libz, and the CoreFoundation, Security, CoreVideo and CoreMedia frameworks. CI caches the binary keyed onbuild-ffmpeg.sh.Evidence
LumeRecorder-0.3.0.zip, and users needbrew install ffmpeg.After:
LumeRecorder-<version>.dmg(32 MB). Mounted in Finder it shows the app with its icon, an arrow, and Applications (checked by screenshot).v*tags only.Merge Danger
Door: two-way
Build and packaging only. No server or API changes, apart from the menu text when ffmpeg is missing.
Blast Radius: release
The
macOS appjob gets slower on a cache miss (two ffmpeg builds). The next tag ships a DMG instead of a zip, so old zip links stay on old releases only.