Repository navigation
feat: macOS menu-bar app that runs the recorder without Docker - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A menu-bar app for people who don't want Docker. It runs
RecorderCorein-process. Docker and the CLI are unchanged.The only change in the core:
runis split so the app can own the lifecycle.App lifecycle:
Defaults: data in
~/Library/Application Support/LumeRecorder. ffmpeg comes from the bundle, then/opt/homebrew/bin, then/usr/local/bin. A GUI app's PATH lacks Homebrew. Env vars still win. Open at Login turns itself on at the first launch from a.app.Evidence
swift run lume-recorderin a terminal.After:
MacApp/scripts/build-app.shproducesLumeRecorder.app(x86_64 + arm64, ad-hoc signed,codesign --verify --strictpasses).DATA_DIR=<tmp> PORT=18090 BONJOUR=0):swift test: 62 tests in 9 suites pass, including real ffmpeg.macOS app(macos-26) passes, building the ad-hoc PR variant.mainand onv*tags, once the secrets exist.Merge Danger
Door: two-way
Additive. The new package sits next to the server, and the core change is a pure extract-function refactor.
Blast Radius: CI
Signing (CI)
On pushes, the
macOS appjob imports a Developer ID certificate into a temporary keychain and signs. Onv*tags it also notarizes with an App Store Connect API key, staples, checks the result withspctl, and attaches the zip to the GitHub release. A tag without the secrets fails rather than shipping an unsigned build. Required secrets (setup steps in the README):MACOS_CERTIFICATE_P12_BASE64,MACOS_CERTIFICATE_PASSWORD,NOTARY_KEY_P8_BASE64,NOTARY_KEY_ID,NOTARY_ISSUER_ID.Once this is merged, pushes to
mainshow the signed path working (or failing). The next release tag needs all five secrets.