docs: correct test count and the DB-update readiness step - #121
Merged
Conversation
Wrap-up doc sweep (T2). Grepped 20 identifiers changed this session across README, CONTRIBUTING, SECURITY, TECHNICAL_GUIDE, the manual test checklist and fresh-vm-smoke; 13 had hits and 3 were stale. Test count 713 -> 726 in README and TECHNICAL_GUIDE. The count moved twice after those files were last touched: the liveness interval-gate tests and the Jellyfin readiness tests. The manual test checklist still described Step 4 as waiting for "Startup complete" via stderr, which is exactly the mechanism that turned out not to work -- docker logs --since returns nothing on a long-lived container. It now describes what the step actually does (healthcheck, or a log marker timestamped after this start, 120s budget) and, more usefully for a tester, records that a failure there means "started but never reported ready" rather than docker refusing to start. TECHNICAL_GUIDE's WaitForContainerReadyAsync row already read "Poll until container is healthy", which was aspirational before and is now accurate. Left as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap-up doc sweep (T2). Grepped 20 identifiers changed this session across README, CONTRIBUTING, SECURITY, TECHNICAL_GUIDE, the manual test checklist and fresh-vm-smoke — 13 had hits, 3 were stale.
Startup completevia stderr — precisely the mechanism that turned out not to work. It now describes what the step actually does, and records that a failure there means started but never reported ready, which is notdocker startfailing. That distinction is the whole reason this was reported as a container-start bug.TECHNICAL_GUIDE'sWaitForContainerReadyAsyncrow already read Poll until container is healthy — aspirational before, accurate now. Left as-is.