release: prepare v1.3.1 - #119
Merged
Merged
Conversation
Patch release carrying the two dependency-manager fixes found immediately after v1.3.0 shipped, both of which landed after that tag. PR #117 - GitHub asset matching required a release asset's filename to contain a platform token ("win64") in addition to matching the declared asset pattern. Neither ImageMagick nor vtracer names its platform that way, so both were vetoed despite exact pattern matches, no download URL ever resolved, and neither could be installed or updated in-app. PR #118 - vtracer's --version banner changed upstream, so its version pattern stopped matching and it reported a blank installed version even once installed. potrace was separately recording "1.16." because a greedy capture swallowed the sentence period ending its banner. v1.3.0 is unaffected for fresh installs, since the MSI seeds these binaries, but its in-app dependency updates for the imaging tools are broken. That is what this patch is for. 721 tests green in Release; zero CS/CA warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release carrying the two dependency-manager fixes found immediately after v1.3.0 shipped. Both landed after the v1.3.0 tag (
ec665fc), so the published v1.3.0 does not contain them.win64) in addition to matching the declared asset pattern. Neither ImageMagick (-portable-Q8-x64.7z) nor vtracer (-x86_64-pc-windows-msvc.zip) names its platform that way, so both were vetoed despite exact pattern matches. No download URL ever resolved → neither could be installed or updated in-app.--versionbanner changed upstream, so its pattern stopped matching and it reported a blank installed version even once installed. potrace separately recorded1.16.because a greedy capture swallowed its banner's sentence period.Impact on v1.3.0: fresh installs are fine — the MSI seeds these binaries — but in-app dependency updates for the imaging tools are broken there. That is what this patch is for.
Verified live in the dev instance before cutting: magick, vtracer and potrace all install and report correct versions.
Verification