Skip to content

feat(plot-module): generic download.handlers for custom export formats - #47

Merged
ESCRI11 merged 1 commit into
masterfrom
feat/download-handlers
Sep 8, 2026
Merged

ESCRI11 merged 1 commit into
masterfrom
feat/download-handlers

Conversation

@ESCRI11

@ESCRI11 ESCRI11 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

PlotModuleServer only knew a fixed set of download formats (png/pdf/svg/csv/excel/html/obj). download.handlers takes a named list of list(ext = , content = function(file)) specs; the names double as download.fmt entries, so a caller can offer e.g. "cx2" (Cytoscape CX2) straight from the plot download menu.

PlotModuleServer(
  "plotmodule",
  ...,
  download.handlers = list(cx2 = list(ext = "cx2", content = cx2_content))
)

Ported verbatim from omicsplayground devel (#1789), where PlotModuleServer lived before the move into bigdash. Needed so the PCSF → Cytoscape export survives the omicsplayground edgy ← devel merge (bigomics/omicsplayground#1890).

🤖 Generated with Claude Code

https://claude.ai/code/session_01TwCeAfAF9p965ed6nZUVjx

PlotModuleServer only knew a fixed set of formats (png/pdf/svg/csv/excel/
html/obj). download.handlers takes a named list of
list(ext=, content=function(file)) specs; the names double as download.fmt
entries, so a caller can offer e.g. "cx2" (Cytoscape CX2) straight from the
plot download menu.

Ported from omicsplayground devel, where PlotModuleServer lived before the
move into bigdash.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TwCeAfAF9p965ed6nZUVjx
ESCRI11 added a commit to bigomics/omicsplayground that referenced this pull request Sep 8, 2026
Conflict resolutions:
- VERSION: keep edgy's 5.0-rc1+edgy260831
- components/board.pcsf/R/util_pcsf.R: edgy deleted the file as dead code,
  but devel's #1789 added pcsf.write_cx2() there and the PCSF panels call it.
  Restore the file with only pcsf.write_cx2(); visplot.PCSF() and
  plot.pcsf.NOTUSED() stay deleted (unreferenced in edgy).
- components/ui/ui-PlotModule.R: stays deleted; PlotModuleServer now lives in
  bigdash. devel's download.handlers argument (used by the new CX2 export) is
  ported there in bigomics/bigdash#47.
- components/board.upload/R/upload_module_preview_counts.R: keep edgy's
  unconditional datapath[1] (the filename gate was removed on purpose in
  d95d6a4) and layer devel's hPTM additions on top.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TwCeAfAF9p965ed6nZUVjx
@ESCRI11
ESCRI11 merged commit f9b78d2 into master Sep 8, 2026
@ESCRI11
ESCRI11 deleted the feat/download-handlers branch September 8, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant