fix: remove await connection() workaround on 404 pages#2425
Conversation
🦋 Changeset detectedLatest commit: 0319791 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
agurtovoy
force-pushed
the
fix/remove-await-connection-workaround
branch
from
71f19a4 to
cb6a6cd
Compare
fikrikarim
left a comment
fikrikarim
left a comment
There was a problem hiding this comment.
From the original PR, the 404 pages not being editable only happened when the catch-all page is PPR (◐) instead of server-rendered (ƒ).
I checked the preview deployment from this branch, and the catch-all page is server-rendered.
ƒ /[locale]/[...rest]
This is probably because we're calling functions that force the page to be server-rendered.
I'm worried that this issue will resurface again in the future if the catch-all page is updated to be properly rendered with PPR.
Perhaps we can test if the 404 page is still editable when the page is rendered with PPR?
agurtovoy
force-pushed
the
fix/remove-await-connection-workaround
branch
from
cb6a6cd to
0319791
Compare
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
3 participants
What/Why?
This was originally put in place to work around the issue of non-published pages not being editable in the builder. That issue has long since been resolved, so the workaround is no longer necessary.
Testing
As an extra test, here's a demo of a 404 page with an editable Makeswift component on it:
Kapture.2025-06-13.at.21.52.13.mp4