Skip to content

Implementing custom vanity URL - #6278

Open
lonesomewalker wants to merge 3 commits into
bigbluebutton:masterfrom
lonesomewalker:master
Open

lonesomewalker wants to merge 3 commits into
bigbluebutton:masterfrom
lonesomewalker:master

Conversation

@lonesomewalker

Copy link
Copy Markdown

Changes neccessary for custom set URL.
Checks if URL already in database, gives hints how valid URL can be chosen.
Previous (already deleted) PR commited to root folder...

Changes neccessary for custom set URL.
Checks if URL already in database, gives hints how valid URL can be chosen.
Previous (already deleted) PR commited to root folder...
Sending only the name (and no user_id), room_params[:user_id] will be empty (nil). Room will be initialized with user_id: nil, probably creating an error by .save (room needs an owner)
@sonarqubecloud

Copy link
Copy Markdown

@lonesomewalker

Copy link
Copy Markdown
Author

Commit ad23f01 is NOT neccessary, but might come when i am done writing more for the API and integrating the PAT (personal access token) to be able to connect with various external tools (like Thunderbird, Outlook, M365) for appointment planning.

@sonarqubecloud

Copy link
Copy Markdown

@farhatahmad

Copy link
Copy Markdown
Collaborator

Thanks for the PR - I'd much rather put this behind a Site Setting (with it defaulted to false) becuase I'm sure a lot of people won't be happy with this (for security reasons)

If you can make that change, I can look into merging this as part of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants