build: require Node >= 22 and build with Node 24 - #30
Open
antobinary wants to merge 1 commit into
Open
antobinary wants to merge 1 commit into
antobinary wants to merge 1 commit into
Conversation
Add an `engines` floor of Node >= 22 to package.json and mirror it into package-lock.json, and bump @types/node to ^24.13.3 so the typings match the runtime the plugin is built with. Move CI onto Node 24 (was Node 20).
imdt-claudiop
approved these changes
Sep 14, 2026
imdt-claudiop
left a comment
There was a problem hiding this comment.
Approved.
Same shape as bigbluebutton/bbb-plugin-picture-in-picture#43, which is already merged: Node 24 across the workflows, nodejs (>= 22) in debian/control, and engines.node >= 22 plus @types/node ^24.13.3 in package.json.
Checked out this branch and ran it on Node 24.9.0:
npm installclean, and package-lock.json shows no drift afterwardsnpx tscpasses (same command as the ts-code-compilation check)npm run lintpasses (same command as the ts-code-validation check)npm run build-bundleproducesdist/TourPlugin.js
I also scanned the rest of the tree for leftover references to the older Node line, and there are none.
Smaller diff than the sibling PRs in the other plugin repos, and that is correct: this repo has no debian/ directory and no deb or publish-tag workflows, so the two TypeScript workflows plus package.json are the whole surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves this plugin onto Node 24 and declares a supported-Node floor.
package.jsongains anenginesfield:"node": ">=22", mirrored intopackage-lock.jsonso the two agree.@types/nodebumped to^24.13.3so the typings match the runtime the pluginis actually built with. It was declared twice, at
^20.3.1and^20.4.4;both are aligned here.
ts-code-compilation.yml—node-version: 20.x->24.xts-code-validation.yml—node-version: 20.x->24.xThis repo has no
debian/directory, no Debian package workflow, and nopublish-tagworkflow, so there is nothing else to update. It is the smallestNode 24 change of the fifteen.
Why
>=22and not>=24The floor is the compatibility contract for anyone consuming or building the
plugin; 22 is still in maintenance and there is no reason to lock it out. The
preferred version is expressed where it takes effect — CI pins 24.
Testing
Against Node 24.20.0 / npm 11.19.0, running the same chain CI does:
npm ci— PASSnpx tsc— PASSnpm run lint— PASSnpm run build-bundle— PASSNotes for review
The
package-lock.jsondiff is confined to theenginesblock and the@types/noderesolution.lockfileVersionis unchanged.