This repository was archived by the owner on Sep 11, 2026. It is now read-only.
build: require Node >= 22 and build with Node 24 - #19
Open
antobinary wants to merge 1 commit into
Open
antobinary wants to merge 1 commit into
antobinary wants to merge 1 commit into
Conversation
Add an `engines` floor of Node >= 22 to package.json and mirror it into package-lock.json, and bump @types/node to ^24.13.3 so the typings match the runtime the plugin is built with. Move CI onto Node 24 (was Node 20). Install Node 24 from NodeSource when building the Debian package. Also move the locked typescript to 5.9.3, within the existing ^5.1.3 range. @types/node 24 uses Symbol.dispose and Disposable, which TypeScript only defines from 5.2, and this repo was pinned at 5.1.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves this plugin onto Node 24 and declares a supported-Node floor.
package.jsongains anenginesfield:"node": ">=22", mirrored intopackage-lock.jsonso the two agree.@types/nodebumped to^24.13.3so the typings match the runtime the pluginis actually built with. It was declared twice, at
^20.3.1and^20.4.4;both are aligned here.
ts-code-compilation.yml—node-version: 20.x->24.xts-code-validation.yml—node-version: 20.x->24.xpublish-tag.yml—node-version: '20'->'24'build-plugin-deb-package.yml— NodeSourcesetup_20.x->setup_24.x, sothe Debian package is built against Node 24
This repo has a Debian package workflow but no
debian/directory, so there isno
Build-Dependsline to raise.Also: TypeScript 5.1.3 -> 5.9.3
Required, not incidental.
@types/node24 usesSymbol.disposeandDisposable, which TypeScript only defines from 5.2. This repo's lock pinned5.1.3, and
npx tscfailed with ~55 errors inside@types/node's owndeclaration files:
package.jsonalready allowed this — the spec was^5.1.3, so only the lockfilepin was holding it back.
npm update typescriptmoved it to 5.9.3 within theexisting range; no declared version changed.
Worth knowing: this repo has no
skipLibCheckintsconfig.json, which is whythe errors surfaced here rather than being silently skipped. That is arguably the
better setting, but it does mean this repo feels typings bumps first.
Why
>=22and not>=24The floor is the compatibility contract for anyone consuming or building the
plugin; 22 is still in maintenance and there is no reason to lock it out. The
preferred version is expressed where it takes effect — CI and the Debian build
both pin 24.
Testing
Against Node 24.20.0 / npm 11.19.0, running the same chain CI does:
npm ci— PASSnpx tsc— PASSnpm run lint— PASSnpm run build-bundle— PASS