Skip to content

test: clear the two CodeQL quality alerts in the test projects #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgard68 merged 1 commit into from
Sep 11, 2026
Merged

test: clear the two CodeQL quality alerts in the test projects #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/DevSecOpsSentinel.Api.Integration.Tests/ApiExceptionHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ public async Task TryHandleAsync_ProblemDetailsServiceDeclinesToWrite_WritesTheP

// Assert
context.Response.Body.Seek(0, SeekOrigin.Begin);
string body = await new StreamReader(context.Response.Body, Encoding.UTF8).ReadToEndAsync();
using StreamReader reader = new(context.Response.Body, Encoding.UTF8);
string body = await reader.ReadToEndAsync();

using JsonDocument document = JsonDocument.Parse(body);

Expand Down
8 changes: 3 additions & 5 deletions tests/DevSecOpsSentinel.Infrastructure.Tests/AcknowledgementTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,10 @@ public void Analyze_CheckoutThatIsReported_IsNotAlsoAcknowledged()
public static TheoryData<string> RulesThatAcknowledgeNothing()
{
TheoryData<string> data = [];
foreach (IWorkflowSecurityRule rule in RuleCatalogue.All())
foreach (IWorkflowSecurityRule rule in RuleCatalogue.All()
.Where(rule => rule is not (ExcessivePermissionsRule or PersistedCredentialsRule)))
{
if (rule is not (ExcessivePermissionsRule or PersistedCredentialsRule))
{
data.Add(rule.RuleId);
}
data.Add(rule.RuleId);
}

return data;
Expand Down