Poll content status before embedding the block-editor Preview panel player - #618
Merged
Merged
Conversation
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
nklhtv
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/editor/components/play-audio/hooks.jsnow always confirmsprocessedbefore embedding, mirroring the classic editor.preview-panel.cy.jscovering a voice-customised post: one confirms the panel shows "Generating…" and never calls the player SDK while status isprocessing, the other confirms it embeds once status isprocessed. Both stub the player SDK script for determinism (the poll path was previously left uncovered here due to real-CDN flakiness).Test plan
npm run lint:js/wp-scripts format --checkon the changed filesnpm run test:unit(Jest) — all suites pass, unaffectednpx cypress run --spec 'tests/cypress/e2e/block-editor/preview-panel.cy.js'— all 3 tests passhooks.jsto the pre-fix version and reran the same spec — the new "still processing" test correctly fails (cy.waitfor the status check times out, since the old code never checks status before embedding)🤖 Generated with Claude Code