FLUSHDB must fail if a data file cannot be unlinked - #20
Open
paulocsanz wants to merge 2 commits into
Open
Conversation
flush_inner clears the index then warns on unlink and returns Ok. A leftover data-* name leaves RAM empty and disk intact.
Clearing the index then warning on unlink returned Ok with disk intact. Unlink first; on error leave the index alone. Truncate the new data-0 so a leftover inode cannot replay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARCHITECTURE.md says flush is a destructive reset with no recovery.
flush_innercleared the in-memory index, warned on unlink errors, thenopen_rwwithout truncate and returned Ok. A leftoverdata-*(or the same inode if unlink of data-0 failed) resurrects the namespace on reopen.Two commits: directory named
data-999.logmakes unlink fail (test expects Err + index intact), then unlink-first + fail-stop +truncate_to(0).