Watch must not trust unauthenticated footer body_len - #16
Open
paulocsanz wants to merge 2 commits into
Open
Conversation
body_len sits outside the CRC. scan_since trusted it, so body_len=records_end made data_end_offset return 0.
body_len sits outside the CRC. scan_since used it raw, so a flip to records_end collapsed the watch window to 0. Reuse read_footer's range+CRC check; on any miss scan to EOF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer trailer layout is
[body][body_len][crc(body)][magic]. CRC does not coverbody_len.read_footerchecks range + CRC.data_end_offset(thescan_sincebound) only looked at magic and subtractedbody_len.Flip
body_lentorecords_end→data_end_offset = 0→ watch catch-up is empty while GET still serves every key.Two commits: failing production test, then
data_end_offsetreusesread_footer. Corrupt length/CRC → scan to EOF.body_lenno longer blinds watch