Release v0.1.4 - #5
Merged
Merged
Conversation
Fd/socket hardening (#4) adds Error variants to an exhaustive enum and restricts trigger-supplied binaries, so it is a breaking bump under 0.x semver rather than a patch. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version bump for the fd/socket hardening in #4. Merging this makes
release.ymlpublishbeyond-handoffand cut the GitHub release, as with v0.1.3.Shipping as a patch per your call. Worth knowing what rides along, since
^0.1resolves to it automatically:Erroris not#[non_exhaustive]and gainedSocketPathTooLongandPeerNotPermitted, so a downstream exhaustivematchon it stops compiling.handoff-supervisorno longer execs an arbitrary client-supplied path;handoff <binary>now requires the path to be inallowed_binaries.Everything else was additive (
sockmodule,take_unix_listener,allowed_uids) or behavioral.Link to Devin session: https://app.devin.ai/sessions/288b845379894277bddeaa82ba171e95
Requested by: @jaredLunde