fix(doctor): run TUI on blocking thread to prevent single-worker starvation#697
Open
rohan-bes wants to merge 1 commit into
Open
fix(doctor): run TUI on blocking thread to prevent single-worker starvation#697rohan-bes wants to merge 1 commit into
rohan-bes wants to merge 1 commit into
Conversation
…vation run_tui's loop has no .await points, so scheduling it with tokio::spawn on a single-worker-thread runtime (the default on single-vCPU hosts) starves every other task, including the sweep it's meant to display, for as long as it runs. Move it to spawn_blocking's dedicated pool instead. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_tui's loop has no.awaitpoints (terminal I/O andcrossterm::event::pollare plain blocking calls), so scheduling it withtokio::spawnstarves every other task on a single-worker-thread runtime — the default on single-vCPU hosts — including the sweep it's meant to display, reading as a permanent hang.tokio::task::spawn_blocking, whose dedicated thread pool never contends with the async worker pool.Test plan
doctoron a single-vCPU host and confirm the TUI no longer hangs