[Merged by Bors] - Helpers to check pipeline cache status#5796
Closed
mockersf wants to merge 3 commits into
Closed
[Merged by Bors] - Helpers to check pipeline cache status#5796mockersf wants to merge 3 commits into
mockersf wants to merge 3 commits into
Conversation
mockersf
added
A-Rendering
Weibye
reviewed
Aug 27, 2022
cart
approved these changes
Aug 29, 2022
djeedai
suggested changes
Aug 31, 2022
djeedai
left a comment
djeedai
left a comment
Contributor
There was a problem hiding this comment.
Change looks good but public items need documentation.
djeedai
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
# Objective - In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so - Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done ## Solution - Add a log with shaders being loaded and their shader defs - add a function on `PipelineCache` to return the number of ready pipelines
|
Pull request successfully merged into main. Build succeeded: |
bors
Bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so - Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done ## Solution - Add a log with shaders being loaded and their shader defs - add a function on `PipelineCache` to return the number of ready pipelines
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - In WASM, creating a pipeline can easily take 2 seconds, freezing the game while doing so - Preloading pipelines can be done during a "loading" state, but it is not trivial to know which pipeline to preload, or when it's done ## Solution - Add a log with shaders being loaded and their shader defs - add a function on `PipelineCache` to return the number of ready pipelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
PipelineCacheto return the number of ready pipelines