Implement eventual consistency for flaky tests - #1110
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a reusable “eventual consistency” assertion helper for integration tests and applies it to previously flaky test cases (Messaging topic subscriptions and AppCheck replay protection) to reduce timing-related failures.
Changes:
- Introduces
IntegrationTestCase::assertEventually()to retry a boolean condition until a timeout. - Updates Messaging AppInstance topic subscription assertions to wait until expected subscription state is observed.
- Refactors AppCheck replay-protection verification test to use
assertEventually()instead of an ad-hoc retry loop.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/IntegrationTestCase.php | Adds assertEventually() helper used to wait for eventually consistent state in integration tests. |
| tests/Integration/Messaging/AppInstanceTest.php | Replaces immediate subscription assertions with a helper that retries until expected topic subscription states are visible. |
| tests/Integration/AppCheckTest.php | Refactors replay-protection verification to use assertEventually() for eventual visibility of consumption state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## 8.x #1110 +/- ##
============================================
+ Coverage 1.67% 40.10% +38.43%
Complexity 1486 1486
============================================
Files 146 146
Lines 4187 4174 -13
============================================
+ Hits 70 1674 +1604
+ Misses 4117 2500 -1617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.