Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Wrong command order #28

Description

@within25
    foreach ($this->chainedCommands as $chainedCommand) {
        $chainedCommand->determinePreOptimisedFileSize();
        $chainedCommand->setImagePath($this->imagePath);
        $chainedCommand->optimise();
        $chainedCommand->determinePostOptimisedFileSize();
    }

first must be setImagePath and only then determinePreOptimisedFileSize

we get an error
Unable to determine pre-optimized fileSize

because $ this-> imagePath is still empty

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions