Refactor/reorganize conan backups - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The PR introduces potentially sensitive real-world infrastructure identifiers in documentation and includes misleading guidance/comments that should be corrected for clarity and safety.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR cleans up Windows-related dotfile snapshots (Terminal and Neovim) and extends the current Windows Terminal configuration with an additional Catppuccin color scheme, while adding a new repository-wide modernization roadmap document.
Changes:
- Remove legacy/duplicate Windows Terminal settings snapshots and a minimal Windows Neovim
init.vim. - Add the Catppuccin Mocha color scheme to the tracked Windows Terminal
settings.jsonand include commented theme scaffolding. - Introduce
ROADMAP.mddescribing a proposed future repository structure and cleanup plan.
File summaries
| File | Description |
|---|---|
| Windows/Terminal/terminal-settings.json | Removed a full Terminal settings snapshot (cleanup / de-dup). |
| Windows/Terminal/settings.json | Adds Catppuccin Mocha scheme and commented theme scaffolding. |
| Windows/Terminal/old-settings.json | Removed an older Terminal settings snapshot (cleanup). |
| Windows/init.vim | Removed a minimal Neovim config stub for Windows. |
| Windows/backup-windows.ps1 | Adds a TODO comment near Chocolatey export step. |
| ROADMAP.md | Adds a modernization/cleanup roadmap and target directory architecture. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "yellow": "#F9E2AF" | ||
| } | ||
| ], | ||
| // Active theme is Nord / system. To use Catppuccin Mocha, set "theme": "Catppuccin Mocha" |
| $chocoExportPath = Join-Path $backupDir "$env:COMPUTERNAME.packages.config" | ||
| Write-Host "[STEP ] Backing up Chocolatey packages..." | ||
| Write-Host "[INFO ] Target: $chocoExportPath" | ||
| # TODO: Remove or ignore *.backup files during backup runs to prevent committing duplicate .backup files |
| - Windows: `helper = manager` (Git Credential Manager) | ||
| - Linux: `helper = libsecret` (or `cache --timeout=3600`) | ||
| - [ ] **Sanitize Internal Enterprise / Work Tokens in `.npmrc`** | ||
| - Remove work-specific internal URLs (`gitlab.create.army.mil`) and auth tokens (`NPM_ASVE_READ_ONLY_TOKEN`) from `mac/.npmrc`. |
| - Remove work-specific internal URLs (`gitlab.create.army.mil`) and auth tokens (`NPM_ASVE_READ_ONLY_TOKEN`) from `mac/.npmrc`. | ||
| - Move enterprise registries to a private work config or machine-local `.npmrc`. | ||
| - [ ] **Protect Private SSH Hosts & Keys** | ||
| - Remove committed hostnames (`mcso-aos`, `atyourservice.benhunter.me`) and key filenames (`LightsailDefaultKey-us-east-2.pem`) from `endeavouros-i3/.ssh/config`. |
| @@ -0,0 +1,238 @@ | |||
| # Dotfiles Cleanup & Modernization Roadmap | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.