Skip to content

A hub that cannot be reached is a formatted error, not a raw TypeError #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lorenzobattistela merged 2 commits into from
Oct 9, 2026
+5 −5
Merged

A hub that cannot be reached is a formatted error, not a raw TypeError #1428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec993d
A hub that cannot be reached is a formatted error, not a raw TypeError
HamedShams Oct 8, 2026
c1148bf
Report an unreachable hub at the import, with a timeout (#1401)
Lorenzobattistela Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bend2/bend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,10 +901,10 @@ export const BEND_HUB = process.env.BEND_HUB ?? "https://hub.bend-lang.com";
export const NAMED = /^([a-z][a-z0-9-]{0,63})@((?:0|[1-9][0-9]*)(?:\.(?:0|[1-9][0-9]*)){3})$/;

async function hub_get(book: Book, sub: string, hash: string, spn?: Span): Promise<string> {
const res = await fetch(BEND_HUB + "/" + sub);
const src = res.ok ? await res.text() : "";
const res = await fetch(BEND_HUB + "/" + sub, { signal: AbortSignal.timeout(30000) }).catch(() => null);
const src = res?.ok ? await res.text().catch(() => "") : "";
const sum = Buffer.from(await crypto.subtle.digest("SHA-256", new TextEncoder().encode(src))).toString("hex");
if (!res.ok || hash.length < 32 || sum.slice(0, hash.length) !== hash || path.posix.normalize("/" + sub) !== "/" + sub) {
if (!res?.ok || hash.length < 32 || sum.slice(0, hash.length) !== hash || path.posix.normalize("/" + sub) !== "/" + sub) {
throw Err(book, ctx_nil(), "a file at " + BEND_HUB + "/" + sub + " hashing to " + hash, undefined, spn);
}
return src;
Expand All @@ -919,8 +919,8 @@ async function name_hash(book: Book, nv: string, spn?: Span): Promise<string> {
if (/^0x[0-9a-f]{32}$/.test(old)) {
return old;
}
const res = await fetch(BEND_HUB + "/name/" + nv).catch(() => null);
const got = res?.ok ? (await res.text()).trim() : "";
const res = await fetch(BEND_HUB + "/name/" + nv, { signal: AbortSignal.timeout(30000) }).catch(() => null);
const got = res?.ok ? (await res.text().catch(() => "")).trim() : "";
if (!/^0x[0-9a-f]{32}$/.test(got)) {
throw Err(book, ctx_nil(), "a package named " + nv + " on " + BEND_HUB
+ (res?.status === 410 ? " (it was taken down)" : ""), undefined, spn);
Expand Down