Repository navigation
test: strengthen ownership and partial-match regressions - #1427
Merged
Lorenzobattistela merged 2 commits intoOct 9, 2026
Merged
Lorenzobattistela merged 2 commits into
Lorenzobattistela merged 2 commits into
Conversation
Collaborator
|
Thanks @vicmcorrea. The But #1314 lists four weak tests, and this PR fixes only one of them. The other three still don't check what they claim to:
Could you extend this PR to cover all of #1314, so the issue can be closed in one go? For the two memory tests, revert the fix each one guards (b3f448e and de63a6f) and check that the test fails. Also, this PR deletes the header of |
Lorenzobattistela
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four regressions in #1314 could pass while ownership leaked or their target code was pruned. This extends the PR to all four fixtures and keeps their explanatory headers:
match_absurd_tailpasses its partial-match function to opaque C/JS sinks without constructingEmptyor invoking it, retaining both emitters' missing-arm lowering.closure_slab_dropallocates an array from runtime input, captures it in a closure, and sends that closure to a sink that verifies and drops the actual capture.closure_value_ownsbuilds fresh trees and appliespickthrough the dynamic closure entry, checking both sums and native arena growth.list_rebox_sumrepeatedly builds, reboxes and consumes bothScalarandPairlists, checking values and native arena growth.The native checks warm the allocator's free lists, then allow at most one additional allocation quantum of reserved arena pages. They measure neither live bytes nor RSS. JavaScript checks values only. The existing foreign twins and test gate need no changes.
Regression sensitivity was checked against targeted broken behavior:
7/3test passing; the new reboxing test fails its arena guard.41000000test passing; the new closure test fails its arena guard.I could not resolve historical commit b3f448e in this repository. The closure control is a reviewed current-equivalent borrowing reversal, not a literal historical revert.
Validation passed for source execution, emitted JS, native default/one/four threads, namespace imports, combined
--checkup, native UBSan, and the final fixtures against current main (3f80b06). Two independent reviews found no actionable issues. Repository gate: 54/54 with the CI-pinned ttok 0.3. Cluster/GPU checks could not run because the configuredclusterhostname does not resolve.Addresses #1314.