Repository navigation
comp.ts drops term_const's ground memo; record_deep_boxed goes 7 deep - #1420
Merged
Merged
Conversation
…le; record_deep_boxed goes 7 deep, the bendlang#843 case its constant table guards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
term_const's ground memo (FL.memo.ground, from #1281) bought nothing measurable: without it, gameoflife and terrain (C and JS) time the same with identical output, and the nested-BoxK chain stays at 0.08s from depth 6 to 8.
emit_ctr's constant table (FL.consts, #843) stays: removing it makes C emission exponential (depth 7: 13.9s, depth 8: 123s, vs 0.08s). record_deep_boxed only went 4 deep, so it didn't catch this. It now also builds the depth-7 constant, which takes 0.6s with the table and 13.8s without it.
Checks: test 1593/1593, repo 54/54. Perf gate not run.