FIX Mantis solver: align with updated Linear Probe Adapter#41
Open
bryan29-ly wants to merge 2 commits into
Open
FIX Mantis solver: align with updated Linear Probe Adapter#41bryan29-ly wants to merge 2 commits into
bryan29-ly wants to merge 2 commits into
Conversation
…s / rename n_iterators to n_estimators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #34 updated the
benchmark_utils/adapters/linear_probe.pybutsolvers/mantis.pywas not completely adapted:run()still passedmax_iter=self.max_iter→ crash.run()readself.n_estimators, but the parameter was declared asn_iteratorspenalty,Candalphawere declared inparametersbut never forwardedto the adapter.
Fix
max_iterargument.n_iteratorsparameter ton_estimatorspenalty,Candalphato the Linear Probe Adaptercc @ambroiseodt