Skip to content

REF Improve over #22#28

Open
felixdivo wants to merge 4 commits into
benchopt:mainfrom
felixdivo:base-tsfm-solver-iteration
Open

REF Improve over #22#28
felixdivo wants to merge 4 commits into
benchopt:mainfrom
felixdivo:base-tsfm-solver-iteration

Conversation

@felixdivo
Copy link
Copy Markdown

#22 was merged a bit early.

@felixdivo
Copy link
Copy Markdown
Author

I'm currently still testing it locally to make sure it runs nicely.

Comment thread benchmark_utils/base_solver.py
@felixdivo
Copy link
Copy Markdown
Author

TODOs:

  • Test thoroughly by hand (e.g., Toto 2 and metrics are likely broken now)

@felixdivo
Copy link
Copy Markdown
Author

cc @kalebphipps :)

@rtavenar
Copy link
Copy Markdown
Contributor

rtavenar commented Jun 1, 2026

I'm OK with this PR, but there are a few conflicts to be resolved before merging.

@felixdivo
Copy link
Copy Markdown
Author

Thanks for checking! I can take of them later this evening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants