Adopt the ringed mark and complete the share metadata - #17
Merged
Conversation
Replace the generic atom icon with the FrontierPhysics mark: the BenchFlow ruler measuring inside a thin orbit, with one electron on that orbit — the benchmark and the physics in one glyph, and visibly part of the BenchFlow family rather than a stock atom. The orbit is drawn as a cut arc rather than a full circle with a disc painted over the gap. A disc has to be painted in the background colour, which the mark cannot know: the same file has to work in the navbar, in a light or dark tab strip, and on the ink Apple icon. As an arc it carries no background of its own and inherits currentColor. The navbar frame goes from 24 to 28px because the orbit fills two thirds of its box where the old ellipses filled seven eighths, so the same frame read undersized beside the wordmark. Share cards are a still frame of the site's own hero — the same geodesic lattice behind the same headline — so a shared link looks like the page it opens. The lattice is regenerated at 1200x630 rather than screenshotted, because the hero canvas is sized to the viewport and animated. /contribute gets its own card; it is the page that will be pasted to prospective contributors. Serving from a sub-path is the trap in the metadata. metadataBase is the bare origin: Next already resolves file-based metadata routes through basePath, so putting /frontierphysics in both would double the prefix. Canonicals are set per route — inheriting the home page's would have dropped /contribute from search results as a duplicate. theme-color is converted from the oklch values in globals.css so the mobile browser chrome matches the page exactly rather than approximately. Verified against the built HTML, not assumed: absolute og:image and twitter:image URLs, summary_large_image, per-route canonicals, and the favicon's dark-mode branch rendered as its own document the way a browser loads it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Keep the share-card logo inside the canvas
When /contribute is unfurled by an Open Graph or Twitter client, the new 1200×630 card visibly clips the brand lockup at the left edge, leaving only the trailing rPhysics text. The identical twitter-image.png has the same defect, so both contribution share assets should be regenerated with sufficient left padding.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mark
The generic atom icon is replaced by the BenchFlow ruler measuring inside a thin
orbit, with one electron on that orbit — the benchmark and the physics in one
glyph, and visibly part of the BenchFlow family rather than a stock atom. No
text in the mark.
The orbit is a cut arc, not a full circle with a disc painted over the gap. A
disc has to be painted in the background colour, which the mark cannot know: the
same file has to work in the navbar, in a light or dark tab strip, and on the ink
Apple icon. As an arc it carries no background of its own and inherits
currentColor.The navbar frame goes from 24 to 28px — the orbit fills two thirds of its box
where the old ellipses filled seven eighths, so the same frame read undersized
beside the wordmark.
Share metadata
The cards are a still frame of the site's own hero — the same geodesic lattice
behind the same headline — so a shared link looks like the page it opens. The
lattice is regenerated at 1200×630 rather than screenshotted, because the hero
canvas is sized to the viewport and animated.
/contributegets its own card;it is the page that will be pasted to prospective contributors.
Serving from a sub-path is the trap here.
metadataBaseis the bare origin:Next already resolves file-based metadata routes through
basePath, so putting/frontierphysicsin both would double the prefix. Canonicals are per route —inheriting the home page's would have dropped
/contributefrom search resultsas a duplicate.
theme-coloris converted from the oklch values inglobals.cssso mobile browser chrome matches the page exactly.og:image/twitter:imagetwitter:cardsummary_large_imagecanonicaltheme-coloricon.svgwith a dark-mode branch,apple-icon.pngat 180×180Verification
Checked against the built HTML rather than assumed: absolute image URLs under
the base path, per-route canonicals, and the favicon's dark-mode branch rendered
as its own document the way a browser loads a favicon. Lint, build, the
task-card assertion and the documentation linter pass locally.
One thing this PR cannot prove: the
/frontierphysicsrewrite on the parentbenchflow.ai project has to forward
/frontierphysics/opengraph-image.pngand/frontierphysics/icon.svg, not only HTML. Worth a scraper check once deployed.