Update ControlTest (Move Validity), add tests, consider refactoring relevant code.

[Darrah]

Refactor code to pull out this responsibility. Tests, as needed, for refactored code. Presumably inspired by earlier tests this semester, or tests from last semester. Submit pull request.

[AidanofVT]

Description: Figure out the purpose of UnitTestsForMakeMove and see if it can be clarified and/or improved.

[AidanofVT]

Alright, as far as I can tell, this is a test for an outdated version of the program. There is no longer a 'Validation' class or a 'Location' class. Judging by the comments, most or all of the assertions should now be applied to GameState/apply_move. I'll experiment with making an equivalent set of tests. @mashfik29 @FaiqHussain You guys should too, then we can compare notes.

[AidanofVT]

Yet again I feel the need to complain that our program is not in any way game-agnostic. All rules are hardcoded. So, I'm about to make a test which will need to be rewritten when the code changes.

[NoraCodes]

Alright, as far as I can tell, this is a test for an outdated version of the program. There is no longer a 'Validation' class or a 'Location' class. Judging by the comments, most or all of the assertions should now be applied to GameState/apply_move. I'll experiment with making an equivalent set of tests.

Observe for context on this #46; you're absolutely correct.

[AidanofVT]

@NoraCodes Am I correct in assessing that the only three currently-working tests are those in riverCrossing/TestConsole, and all new test aught to be placed there?

[NoraCodes]

No - tests/ is a fine place for tests, but everything that was there was testing classes that don't exist (from oldsrc/).

[FaiqHussain]

Hey Aiden so you were going to send some questions after which we were going to work on this.

[Darrah]

Heavily revising previous tests.

[AidanofVT]

@mashfik29 Here's the invite to our breakout meeting: https://zoom.us/j/313203722?pwd=YU40cFVYMzJqT2J2dmN0d01wY0ZpZz09

[AidanofVT]

@FaiqHussain @mashfik29 I just pushed a change to our update_control_test branch which replaces the UnitTestsForMakeMove class with a test_moveValidity class. This class contains a function which should create a list of every possible gamestate. I can't get this test to work. I've been using "python -m unittest test_moveValidity" from within the test directory. I also tried the command from the parent RIVERCROSSINGPUZZLES directory. The result is always "ImportError: Failed to import test module: test_moveValidity." I don't know what this means or how to fix it. Can you guy apply your knowledge and see if you can make progress?