support regexp buffer boundaries - #554
Open
sno2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this implements the stage 3 RegExp Buffer Boundaries proposal: https://github.com/tc39/proposal-regexp-buffer-boundaries
I tested against this test262 PR: tc39/test262#4975
There were two failing tests from
./run-test262 -c test262.confand./run-test262-debug -c test262.conf:The first failure is a test that had not been updated to allow these new escapes, so I have left a note on the test262 PR: tc39/test262#4975 (comment). The second seems to be a new test that is unrelated to my changes.
I have not updated the test262 commit in this repository because the test262 PR has not been merged yet.
Closes #544